Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(813)

Unified Diff: mandoline/tab/frame.h

Issue 1239313004: More html_viewer OOPIF changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix compile Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/html_viewer/test_html_viewer_impl.cc ('k') | mandoline/tab/frame.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mandoline/tab/frame.h
diff --git a/mandoline/tab/frame.h b/mandoline/tab/frame.h
index e4c35139b54cffcdcffe569707fe997b34d3fbb0..57e7e464ea63170c5fe0e8a8c5d7f386702a075f 100644
--- a/mandoline/tab/frame.h
+++ b/mandoline/tab/frame.h
@@ -62,6 +62,10 @@ class Frame : public mojo::ViewObserver, public FrameTreeServer {
FrameUserData* user_data() { return user_data_.get(); }
+ const std::vector<Frame*>& children() { return children_; }
+
+ const mojo::String& name() const { return name_; }
+
// Returns true if this Frame or any child Frame is loading.
bool IsLoading() const;
@@ -82,6 +86,7 @@ class Frame : public mojo::ViewObserver, public FrameTreeServer {
// Notifies the client and all descendants as appropriate.
void NotifyAdded(const Frame* source, const Frame* added_node);
void NotifyRemoved(const Frame* source, const Frame* removed_node);
+ void NotifyFrameNameChanged(const Frame* source);
// mojo::ViewObserver:
void OnViewDestroying(mojo::View* view) override;
@@ -94,6 +99,7 @@ class Frame : public mojo::ViewObserver, public FrameTreeServer {
void LoadingStarted() override;
void LoadingStopped() override;
void ProgressChanged(double progress) override;
+ void SetFrameName(const mojo::String& name) override;
FrameTree* const tree_;
mojo::View* view_;
@@ -107,6 +113,8 @@ class Frame : public mojo::ViewObserver, public FrameTreeServer {
bool loading_;
double progress_;
+ mojo::String name_;
+
mojo::Binding<FrameTreeServer> frame_tree_server_binding_;
DISALLOW_COPY_AND_ASSIGN(Frame);
« no previous file with comments | « components/html_viewer/test_html_viewer_impl.cc ('k') | mandoline/tab/frame.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698