Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1239313004: More html_viewer OOPIF changes (Closed)

Created:
5 years, 5 months ago by sky
Modified:
5 years, 5 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More html_viewer OOPIF changes Propagates frame name changes correctly. Add support for origin and sandbox flags, but not fully wired up yet. Adds more test coverage. BUG=479172, 490221 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/65747e7f719a69ab4195ab93a2354217c2d0d611 Cr-Commit-Position: refs/heads/master@{#339686}

Patch Set 1 #

Patch Set 2 : tweaks #

Patch Set 3 : merge #

Patch Set 4 : fix compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+352 lines, -43 lines) Patch
M components/html_viewer/ax_provider_apptest.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M components/html_viewer/document_resource_waiter.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/document_resource_waiter.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/html_viewer/frame.h View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M components/html_viewer/frame.cc View 1 2 6 chunks +34 lines, -8 lines 0 comments Download
M components/html_viewer/frame_tree_manager.h View 3 chunks +5 lines, -3 lines 0 comments Download
M components/html_viewer/frame_tree_manager.cc View 7 chunks +26 lines, -12 lines 0 comments Download
M components/html_viewer/html_frame_apptest.cc View 6 chunks +135 lines, -10 lines 0 comments Download
M components/html_viewer/html_viewer.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/public/interfaces/test_html_viewer.mojom View 1 chunk +3 lines, -0 lines 0 comments Download
M components/html_viewer/test_html_viewer_impl.h View 2 chunks +12 lines, -3 lines 0 comments Download
M components/html_viewer/test_html_viewer_impl.cc View 2 chunks +67 lines, -4 lines 0 comments Download
M mandoline/tab/frame.h View 4 chunks +8 lines, -0 lines 0 comments Download
M mandoline/tab/frame.cc View 3 chunks +20 lines, -0 lines 0 comments Download
M mandoline/tab/frame_apptest.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M mandoline/tab/frame_connection.h View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/tab/frame_connection.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mandoline/tab/frame_tree.h View 2 chunks +2 lines, -1 line 0 comments Download
M mandoline/tab/frame_tree.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mandoline/tab/public/interfaces/frame_tree.mojom View 3 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sky
5 years, 5 months ago (2015-07-21 17:04:38 UTC) #1
Ben Goodger (Google)
lgtm
5 years, 5 months ago (2015-07-21 17:11:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239313004/60001
5 years, 5 months ago (2015-07-21 17:19:12 UTC) #5
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-21 17:34:24 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 17:35:13 UTC) #7
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/65747e7f719a69ab4195ab93a2354217c2d0d611
Cr-Commit-Position: refs/heads/master@{#339686}

Powered by Google App Engine
This is Rietveld 408576698