Re-land: cc: Added antialiasing support for solid color layers

cc/gl_renderer.cc

 // Copyright 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/gl_renderer.h"
 
 #include <set>
 #include <string>
 #include <vector>
 
@@ skipping 704 matching lines @@
     setShaderOpacity(quad->opacity(), shaderAlphaLocation);
     setShaderQuadF(surfaceQuad, shaderQuadLocation);
     drawQuadGeometry(frame, quad->quadTransform(), quad->rect, shaderMatrixLocation);
 
     // Flush the compositor context before the filter bitmap goes out of
     // scope, so the draw gets processed before the filter texture gets deleted.
     if (filterBitmap.getTexture())
         m_context->flush();
 }
 
+struct SolidColorProgramUniforms {
+    unsigned program;
+    unsigned matrixLocation;
+    unsigned colorLocation;
+    unsigned pointLocation;
+    unsigned texScaleLocation;
+    unsigned edgeLocation;
+};
+
+template<class T>
+static void solidColorUniformLocation(T program, SolidColorProgramUniforms& uniforms)
+{
+    uniforms.program = program->program();
+    uniforms.matrixLocation = program->vertexShader().matrixLocation();
+    uniforms.colorLocation = program->fragmentShader().colorLocation();
+    uniforms.pointLocation = program->vertexShader().pointLocation();
+    uniforms.texScaleLocation = program->vertexShader().texScaleLocation();
+    uniforms.edgeLocation = program->fragmentShader().edgeLocation();
+}
+
+bool GLRenderer::setupQuadForAntialiasing(const gfx::Transform& deviceTransform, const DrawQuad* quad,
+                                          gfx::QuadF* localQuad, float* edge) const
+{
+    gfx::Rect tileRect = quad->visible_rect;
+
+    bool clipped = false;
+    gfx::QuadF deviceLayerQuad = MathUtil::mapQuad(deviceTransform, gfx::QuadF(quad->visibleContentRect()), clipped);
+    DCHECK(!clipped);
+
+    // TODO(reveman): Axis-aligned is not enough to avoid anti-aliasing.
+    // Bounding rectangle for quad also needs to be expressible as
+    // an integer rectangle. crbug.com/169374
+    bool isAxisAlignedInTarget = deviceLayerQuad.IsRectilinear();
+    bool useAA = !clipped && !isAxisAlignedInTarget && quad->IsEdge();
+
+    if (!useAA)
+      return false;
+
+    LayerQuad deviceLayerBounds = LayerQuad(gfx::QuadF(deviceLayerQuad.BoundingBox()));
+    deviceLayerBounds.inflateAntiAliasingDistance();
+
+    LayerQuad deviceLayerEdges = LayerQuad(deviceLayerQuad);
+    deviceLayerEdges.inflateAntiAliasingDistance();
+
+    deviceLayerEdges.toFloatArray(edge);
+    deviceLayerBounds.toFloatArray(&edge[12]);
+
+    gfx::PointF bottomRight = tileRect.bottom_right();
+    gfx::PointF bottomLeft = tileRect.bottom_left();
+    gfx::PointF topLeft = tileRect.origin();
+    gfx::PointF topRight = tileRect.top_right();
+
+    // Map points to device space.
+    bottomRight = MathUtil::mapPoint(deviceTransform, bottomRight, clipped);
+    DCHECK(!clipped);
+    bottomLeft = MathUtil::mapPoint(deviceTransform, bottomLeft, clipped);
+    DCHECK(!clipped);
+    topLeft = MathUtil::mapPoint(deviceTransform, topLeft, clipped);
+    DCHECK(!clipped);
+    topRight = MathUtil::mapPoint(deviceTransform, topRight, clipped);
+    DCHECK(!clipped);
+
+    LayerQuad::Edge bottomEdge(bottomRight, bottomLeft);
+    LayerQuad::Edge leftEdge(bottomLeft, topLeft);
+    LayerQuad::Edge topEdge(topLeft, topRight);
+    LayerQuad::Edge rightEdge(topRight, bottomRight);
+
+    // Only apply anti-aliasing to edges not clipped by culling or scissoring.
+    if (quad->IsTopEdge() && tileRect.y() == quad->rect.y())
+        topEdge = deviceLayerEdges.top();
+    if (quad->IsLeftEdge() && tileRect.x() == quad->rect.x())
+        leftEdge = deviceLayerEdges.left();
+    if (quad->IsRightEdge() && tileRect.right() == quad->rect.right())
+        rightEdge = deviceLayerEdges.right();
+    if (quad->IsBottomEdge() && tileRect.bottom() == quad->rect.bottom())
+        bottomEdge = deviceLayerEdges.bottom();
+
+    float sign = gfx::QuadF(tileRect).IsCounterClockwise() ? -1 : 1;
+    bottomEdge.scale(sign);
+    leftEdge.scale(sign);
+    topEdge.scale(sign);
+    rightEdge.scale(sign);
+
+    // Create device space quad.
+    LayerQuad deviceQuad(leftEdge, topEdge, rightEdge, bottomEdge);
+
+    // Map device space quad to local space. deviceTransform has no 3d component since it was flattened, so we don't need to project.
+    // We should have already checked that the transform was uninvertible above.
+    gfx::Transform inverseDeviceTransform(gfx::Transform::kSkipInitialization);
+    bool didInvert = deviceTransform.GetInverse(&inverseDeviceTransform);
+    DCHECK(didInvert);
+    *localQuad = MathUtil::mapQuad(inverseDeviceTransform, deviceQuad.ToQuadF(), clipped);
+    // We should not DCHECK(!clipped) here, because anti-aliasing inflation may cause deviceQuad to become
+    // clipped. To our knowledge this scenario does not need to be handled differently than the unclipped case.
+
+    return true;
+}
+
 void GLRenderer::drawSolidColorQuad(const DrawingFrame& frame, const SolidColorDrawQuad* quad)
 {
-    setBlendEnabled(quad->ShouldDrawWithBlending());
+    gfx::Rect tileRect = quad->visible_rect;
 
-    const SolidColorProgram* program = solidColorProgram();
-    setUseProgram(program->program());
+    gfx::Transform deviceTransform = frame.windowMatrix * frame.projectionMatrix * quad->quadTransform();
+    deviceTransform.FlattenTo2d();
+    if (!deviceTransform.IsInvertible())
+        return;
+
+    gfx::QuadF localQuad = gfx::QuadF(gfx::RectF(tileRect));
+    float edge[24];
+    bool useAA = setupQuadForAntialiasing(deviceTransform, quad, &localQuad, edge);
+
+    SolidColorProgramUniforms uniforms;
+    if (useAA)
+        solidColorUniformLocation(solidColorProgramAA(), uniforms);
+    else
+        solidColorUniformLocation(solidColorProgram(), uniforms);
+    setUseProgram(uniforms.program);
 
     SkColor color = quad->color;
     float opacity = quad->opacity();
     float alpha = (SkColorGetA(color) / 255.0) * opacity;
 
-    GLC(context(), context()->uniform4f(program->fragmentShader().colorLocation(), (SkColorGetR(color) / 255.0) * alpha, (SkColorGetG(color) / 255.0) * alpha, (SkColorGetB(color) / 255.0) * alpha, alpha));
+    GLC(context(), context()->uniform4f(uniforms.colorLocation,
+                                        (SkColorGetR(color) / 255.0) * alpha,
+                                        (SkColorGetG(color) / 255.0) * alpha,
+                                        (SkColorGetB(color) / 255.0) * alpha,
+                                        alpha));
 
-    drawQuadGeometry(frame, quad->quadTransform(), quad->rect, program->vertexShader().matrixLocation());
+    GLC(context(), context()->uniform2f(uniforms.texScaleLocation, 1.0f, 1.0f));
+
+    if (useAA) {
+        GLC(context(), context()->uniform3fv(uniforms.edgeLocation, 8, edge));
+    }
+
+    // Enable blending when the quad properties require it or if we decided
+    // to use antialiasing.
+    setBlendEnabled(quad->ShouldDrawWithBlending() || useAA);
+
+    // Normalize to tileRect.
+    localQuad.Scale(1.0f / tileRect.width(), 1.0f / tileRect.height());
+
+    setShaderQuadF(localQuad, uniforms.pointLocation);
+
+    // The tile quad shader behaves differently compared to all other shaders.

[reveman, 2013/03/04 22:59:06]

we shouldn't be referring to the tile quad shader here. this comment also
happens to be false after this change. we now have two shaders that behaves
differently :) please adjust this comment.

[ernstm, 2013/03/05 00:46:51]

Done.

+    // The transform and vertex data are used to figure out the extents that the
+    // un-antialiased quad should have and which vertex this is and the float
+    // quad passed in via uniform is the actual geometry that gets used to draw
+    // it. This is why this centered rect is used and not the original quadRect.
+    gfx::RectF centeredRect(gfx::PointF(-0.5 * tileRect.width(), -0.5 * tileRect.height()), tileRect.size());
+    drawQuadGeometry(frame, quad->quadTransform(), centeredRect, uniforms.matrixLocation);
 }
 
 struct TileProgramUniforms {
     unsigned program;
     unsigned samplerLocation;
     unsigned vertexTexTransformLocation;
     unsigned fragmentTexTransformLocation;
     unsigned edgeLocation;
     unsigned matrixLocation;
     unsigned alphaLocation;
@@ skipping 57 matching lines @@
     float vertexTexScaleX = tileRect.width() / clampGeomRect.width();
     float vertexTexScaleY = tileRect.height() / clampGeomRect.height();
 
     // Map to normalized texture coordinates.
     const gfx::Size& textureSize = quad->texture_size;
     float fragmentTexTranslateX = clampTexRect.x() / textureSize.width();
     float fragmentTexTranslateY = clampTexRect.y() / textureSize.height();
     float fragmentTexScaleX = clampTexRect.width() / textureSize.width();
     float fragmentTexScaleY = clampTexRect.height() / textureSize.height();
 
-    gfx::QuadF localQuad;
     gfx::Transform deviceTransform = frame.windowMatrix * frame.projectionMatrix * quad->quadTransform();
     deviceTransform.FlattenTo2d();
     if (!deviceTransform.IsInvertible())
         return;
 
-    bool clipped = false;
-    gfx::QuadF deviceLayerQuad = MathUtil::mapQuad(deviceTransform, gfx::QuadF(quad->visibleContentRect()), clipped);
-    DCHECK(!clipped);
-
-    // TODO(reveman): Axis-aligned is not enough to avoid anti-aliasing.
-    // Bounding rectangle for quad also needs to be expressible as
-    // an integer rectangle. crbug.com/169374
-    bool isAxisAlignedInTarget = deviceLayerQuad.IsRectilinear();
-    bool useAA = !clipped && !isAxisAlignedInTarget && quad->IsEdge();
+    gfx::QuadF localQuad = gfx::QuadF(gfx::RectF(tileRect));
+    float edge[24];
+    bool useAA = setupQuadForAntialiasing(deviceTransform, quad, &localQuad, edge);
 
     TileProgramUniforms uniforms;
     if (useAA) {
         if (quad->swizzle_contents)
             tileUniformLocation(tileProgramSwizzleAA(), uniforms);
         else
             tileUniformLocation(tileProgramAA(), uniforms);
     } else {
         if (quad->ShouldDrawWithBlending()) {
             if (quad->swizzle_contents)
                 tileUniformLocation(tileProgramSwizzle(), uniforms);
             else
                 tileUniformLocation(tileProgram(), uniforms);
         } else {
             if (quad->swizzle_contents)
                 tileUniformLocation(tileProgramSwizzleOpaque(), uniforms);
             else
                 tileUniformLocation(tileProgramOpaque(), uniforms);
         }
     }
 
     setUseProgram(uniforms.program);
     GLC(context(), context()->uniform1i(uniforms.samplerLocation, 0));
     bool scaled = (texToGeomScaleX != 1 || texToGeomScaleY != 1);
     GLenum filter = (useAA || scaled || !quad->quadTransform().IsIdentityOrIntegerTranslation()) ? GL_LINEAR : GL_NEAREST;
     ResourceProvider::ScopedSamplerGL quadResourceLock(m_resourceProvider, quad->resource_id, GL_TEXTURE_2D, filter);
 
     if (useAA) {
-        LayerQuad deviceLayerBounds = LayerQuad(gfx::QuadF(deviceLayerQuad.BoundingBox()));
-        deviceLayerBounds.inflateAntiAliasingDistance();
-
-        LayerQuad deviceLayerEdges = LayerQuad(deviceLayerQuad);
-        deviceLayerEdges.inflateAntiAliasingDistance();
-
-        float edge[24];
-        deviceLayerEdges.toFloatArray(edge);
-        deviceLayerBounds.toFloatArray(&edge[12]);
         GLC(context(), context()->uniform3fv(uniforms.edgeLocation, 8, edge));
-
         GLC(context(), context()->uniform4f(uniforms.vertexTexTransformLocation, vertexTexTranslateX, vertexTexTranslateY, vertexTexScaleX, vertexTexScaleY));
         GLC(context(), context()->uniform4f(uniforms.fragmentTexTransformLocation, fragmentTexTranslateX, fragmentTexTranslateY, fragmentTexScaleX, fragmentTexScaleY));
-
-        gfx::PointF bottomRight = tileRect.bottom_right();
-        gfx::PointF bottomLeft = tileRect.bottom_left();
-        gfx::PointF topLeft = tileRect.origin();
-        gfx::PointF topRight = tileRect.top_right();
-
-        // Map points to device space.
-        bottomRight = MathUtil::mapPoint(deviceTransform, bottomRight, clipped);
-        DCHECK(!clipped);
-        bottomLeft = MathUtil::mapPoint(deviceTransform, bottomLeft, clipped);
-        DCHECK(!clipped);
-        topLeft = MathUtil::mapPoint(deviceTransform, topLeft, clipped);
-        DCHECK(!clipped);
-        topRight = MathUtil::mapPoint(deviceTransform, topRight, clipped);
-        DCHECK(!clipped);
-
-        LayerQuad::Edge bottomEdge(bottomRight, bottomLeft);
-        LayerQuad::Edge leftEdge(bottomLeft, topLeft);
-        LayerQuad::Edge topEdge(topLeft, topRight);
-        LayerQuad::Edge rightEdge(topRight, bottomRight);
-
-        // Only apply anti-aliasing to edges not clipped by culling or scissoring.
-        if (quad->IsTopEdge() && tileRect.y() == quad->rect.y())
-            topEdge = deviceLayerEdges.top();
-        if (quad->IsLeftEdge() && tileRect.x() == quad->rect.x())
-            leftEdge = deviceLayerEdges.left();
-        if (quad->IsRightEdge() && tileRect.right() == quad->rect.right())
-            rightEdge = deviceLayerEdges.right();
-        if (quad->IsBottomEdge() && tileRect.bottom() == quad->rect.bottom())
-            bottomEdge = deviceLayerEdges.bottom();
-
-        float sign = gfx::QuadF(tileRect).IsCounterClockwise() ? -1 : 1;
-        bottomEdge.scale(sign);
-        leftEdge.scale(sign);
-        topEdge.scale(sign);
-        rightEdge.scale(sign);
-
-        // Create device space quad.
-        LayerQuad deviceQuad(leftEdge, topEdge, rightEdge, bottomEdge);
-
-        // Map device space quad to local space. deviceTransform has no 3d component since it was flattened, so we don't need to project.
-        // We should have already checked that the transform was uninvertible above.
-        gfx::Transform inverseDeviceTransform(gfx::Transform::kSkipInitialization);
-        bool didInvert = deviceTransform.GetInverse(&inverseDeviceTransform);
-        DCHECK(didInvert);
-        localQuad = MathUtil::mapQuad(inverseDeviceTransform, deviceQuad.ToQuadF(), clipped);
-
-        // We should not DCHECK(!clipped) here, because anti-aliasing inflation may cause deviceQuad to become
-        // clipped. To our knowledge this scenario does not need to be handled differently than the unclipped case.
     } else {
         // Move fragment shader transform to vertex shader. We can do this while
         // still producing correct results as fragmentTexTransformLocation
         // should always be non-negative when tiles are transformed in a way
         // that could result in sampling outside the layer.
         vertexTexScaleX *= fragmentTexScaleX;
         vertexTexScaleY *= fragmentTexScaleY;
         vertexTexTranslateX *= fragmentTexScaleX;
         vertexTexTranslateY *= fragmentTexScaleY;
         vertexTexTranslateX += fragmentTexTranslateX;
         vertexTexTranslateY += fragmentTexTranslateY;
 
         GLC(context(), context()->uniform4f(uniforms.vertexTexTransformLocation, vertexTexTranslateX, vertexTexTranslateY, vertexTexScaleX, vertexTexScaleY));
-
-        localQuad = gfx::RectF(tileRect);
     }
 
     // Enable blending when the quad properties require it or if we decided
     // to use antialiasing.
     setBlendEnabled(quad->ShouldDrawWithBlending() || useAA);
 
     // Normalize to tileRect.
     localQuad.Scale(1.0f / tileRect.width(), 1.0f / tileRect.height());
 
     setShaderOpacity(quad->opacity(), uniforms.alphaLocation);
     setShaderQuadF(localQuad, uniforms.pointLocation);
 
     // The tile quad shader behaves differently compared to all other shaders.

[reveman, 2013/03/04 22:59:06]

adjust this comment too.

[ernstm, 2013/03/05 00:46:51]

Done.

     // The transform and vertex data are used to figure out the extents that the
     // un-antialiased quad should have and which vertex this is and the float
     // quad passed in via uniform is the actual geometry that gets used to draw
     // it. This is why this centered rect is used and not the original quadRect.
     gfx::RectF centeredRect(gfx::PointF(-0.5 * tileRect.width(), -0.5 * tileRect.height()), tileRect.size());
     drawQuadGeometry(frame, quad->quadTransform(), centeredRect, uniforms.matrixLocation);
 }
 
 void GLRenderer::drawYUVVideoQuad(const DrawingFrame& frame, const YUVVideoDrawQuad* quad)
 {
@@ skipping 681 matching lines @@
 {
     if (!m_solidColorProgram)
         m_solidColorProgram = make_scoped_ptr(new SolidColorProgram(m_context));
     if (!m_solidColorProgram->initialized()) {
         TRACE_EVENT0("cc", "GLRenderer::solidColorProgram::initialize");
         m_solidColorProgram->initialize(m_context, m_isUsingBindUniform);
     }
     return m_solidColorProgram.get();
 }
 
+const GLRenderer::SolidColorProgramAA* GLRenderer::solidColorProgramAA()
+{
+    if (!m_solidColorProgramAA)
+         m_solidColorProgramAA = make_scoped_ptr(new SolidColorProgramAA(m_context));
+    if (!m_solidColorProgramAA->initialized()) {
+         TRACE_EVENT0("cc", "GLRenderer::solidColorProgramAA::initialize");
+         m_solidColorProgramAA->initialize(m_context, m_isUsingBindUniform);
+    }
+    return m_solidColorProgramAA.get();
+}
+
 const GLRenderer::RenderPassProgram* GLRenderer::renderPassProgram()
 {
     DCHECK(m_renderPassProgram);
     if (!m_renderPassProgram->initialized()) {
         TRACE_EVENT0("cc", "GLRenderer::renderPassProgram::initialize");
         m_renderPassProgram->initialize(m_context, m_isUsingBindUniform);
     }
     return m_renderPassProgram.get();
 }
 
@@ skipping 186 matching lines @@
     if (m_textureIOSurfaceProgram)
         m_textureIOSurfaceProgram->cleanup(m_context);
 
     if (m_videoYUVProgram)
         m_videoYUVProgram->cleanup(m_context);
     if (m_videoStreamTextureProgram)
         m_videoStreamTextureProgram->cleanup(m_context);
 
     if (m_solidColorProgram)
         m_solidColorProgram->cleanup(m_context);
+    if (m_solidColorProgramAA)
+      m_solidColorProgramAA->cleanup(m_context);
 
     if (m_offscreenFramebufferId)
         GLC(m_context, m_context->deleteFramebuffer(m_offscreenFramebufferId));
 
     releaseRenderPassTextures();
 }
 
 bool GLRenderer::isContextLost()
 {
     return (m_context->getGraphicsResetStatusARB() != GL_NO_ERROR);
 }
 
 }  // namespace cc