gm/mixedtextblobs.cpp - Issue 1239303003: fix typeface leak

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/mixedtextblobs.cpp

Issue 1239303003: fix typeface leak (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gm/mixedtextblobs.cpp

diff --git a/gm/mixedtextblobs.cpp b/gm/mixedtextblobs.cpp

index 53bd7f7e3614a75856b8c20ba94a7e9a30d0506d..681b0b7cb1d0714425602825ffead09917ea8de1 100644

--- a/gm/mixedtextblobs.cpp

+++ b/gm/mixedtextblobs.cpp

@@ -39,7 +39,7 @@ public:

protected:

void onOnceBeforeDraw() override {

- fEmojiTypeface.reset(sk_tool_utils::emoji_typeface());

+ sk_tool_utils::emoji_typeface(&fEmojiTypeface);

fEmojiText = sk_tool_utils::emoji_sample_text();

fReallyBigATypeface.reset(GetResourceAsTypeface("/fonts/ReallyBigA.ttf"));

« no previous file with comments | « gm/dftext.cpp ('k') | tools/sk_tool_utils.h » ('j') | no next file with comments »