sdk/lib/async/stream.dart - Issue 12393009: Change and structure how Stream implementations do callbacks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/async/stream.dart

Issue 12393009: Change and structure how Stream implementations do callbacks. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/async/stream.dart

diff --git a/sdk/lib/async/stream.dart b/sdk/lib/async/stream.dart

index 4814427b0690e4656cd345eb7654a24a2f11198a..185ce2a97c983403a01337265b834ec73a01699d 100644

--- a/sdk/lib/async/stream.dart

+++ b/sdk/lib/async/stream.dart

@@ -20,8 +20,14 @@ part of dart.async;

* or to temporarily pause events from the stream.

* When an event is fired, the listeners at that time are informed.

- * If a listener is added or removed while an event is being fired, the change

- * will only take effect after the event is completely fired.

+ * If a listener is added while an event is being fired, the change

+ * will only take effect after the event is completely fired. If a listener

+ * is canceled, it immediately stops receiving events.

+ *

+ * When the "done" event is fired, subscribers are unsubscribed before

+ * receiving the event. After the event has been sent, the stream has no

+ * subscribers. Adding new subscribers after this point is allowed, but

+ * they will just receive a new "done" event as soon as possible.

* Streams always respect "pause" requests. If necessary they need to buffer

* their input, but often, and preferably, they can simply request their input

« no previous file with comments | « sdk/lib/async/async_error.dart ('k') | sdk/lib/async/stream_controller.dart » ('j') | no next file with comments »