Issue 12393008: [v8-dev] Split and replace the EmitVFPTruncate routine to only do what is needed. Floor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12393008: [v8-dev] Split and replace the EmitVFPTruncate routine to only do what is needed. Floor (Closed)

Created:
7 years, 9 months ago by Rodolph Perfetta

Modified:
7 years, 9 months ago

Reviewers:
hans, ulan, danno

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

More Reviews

Description

Split and replace the EmitVFPTruncate routine to only do what is needed. Floor and Round have been rewritten to use the default rounding mode. BUG=none TEST=none Committed: https://code.google.com/p/v8/source/detail?r=13833

Patch Set 1 #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+154 lines, -251 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	3 chunks	+6 lines, -20 lines	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	4 chunks	+39 lines, -80 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+19 lines, -20 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	2 chunks	+58 lines, -64 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	3 chunks	+32 lines, -67 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

hans

Looks good as far as I can tell. https://codereview.chromium.org/12393008/diff/1/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): https://codereview.chromium.org/12393008/diff/1/src/arm/stub-cache-arm.cc#newcode2164 src/arm/stub-cache-arm.cc:2164: // ...

7 years, 9 months ago (2013-03-01 14:47:54 UTC) #2

Rodolph Perfetta

7 years, 9 months ago (2013-03-05 19:36:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r13833 (presubmit successful).

Expand Messages | Collapse Messages