src/utils/debugger/SkDebugCanvas.h - Issue 1239193002: remove all guards for changes to drawBitmapRect / drawImageRect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/debugger/SkDebugCanvas.h

Issue 1239193002: remove all guards for changes to drawBitmapRect / drawImageRect (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/utils/debugger/SkDebugCanvas.h

diff --git a/src/utils/debugger/SkDebugCanvas.h b/src/utils/debugger/SkDebugCanvas.h

index 4f5f226e82ef1e7953df05cc3d1c15e1ad16c903..e0aed6223da74bc1da4b94563ed50ce00f68a1c0 100644

--- a/src/utils/debugger/SkDebugCanvas.h

+++ b/src/utils/debugger/SkDebugCanvas.h

@@ -198,10 +198,10 @@ protected:

void onDrawPath(const SkPath&, const SkPaint&) override;

void onDrawBitmap(const SkBitmap&, SkScalar left, SkScalar top, const SkPaint*) override;

void onDrawBitmapRect(const SkBitmap&, const SkRect* src, const SkRect& dst, const SkPaint*,

- SK_VIRTUAL_CONSTRAINT_TYPE) override;

+ SrcRectConstraint) override;

void onDrawImage(const SkImage*, SkScalar left, SkScalar top, const SkPaint*) override;

void onDrawImageRect(const SkImage*, const SkRect* src, const SkRect& dst,

- const SkPaint* SRC_RECT_CONSTRAINT_PARAM(constraint)) override;

+ const SkPaint*, SrcRectConstraint) override;

void onDrawBitmapNine(const SkBitmap&, const SkIRect& center, const SkRect& dst,

const SkPaint*) override;

void onDrawSprite(const SkBitmap&, int left, int top, const SkPaint*) override;

« no previous file with comments | « src/utils/SkPaintFilterCanvas.cpp ('k') | src/utils/debugger/SkDebugCanvas.cpp » ('j') | no next file with comments »