Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 1239193002: remove all guards for changes to drawBitmapRect / drawImageRect (Closed)

Created:
5 years, 5 months ago by reed1
Modified:
5 years, 4 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove all guards for changes to drawBitmapRect / drawImageRect BUG=skia: Committed: https://skia.googlesource.com/skia/+/562fe4767cc73e08a4e039362bc0336aea66ecfb

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -160 lines) Patch
M include/core/SkBitmapDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkCanvas.h View 4 chunks +3 lines, -59 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +1 line, -1 line 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/utils/SkLuaCanvas.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 1 chunk +2 lines, -2 lines 0 comments Download
M include/utils/SkPaintFilterCanvas.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkBitmapDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 4 chunks +6 lines, -18 lines 0 comments Download
M src/core/SkDevice.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M src/core/SkRecorder.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/core/SkRecorder.cpp View 2 chunks +3 lines, -9 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/pdf/SkPDFDevice.h View 1 1 chunk +2 lines, -4 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 3 chunks +4 lines, -9 lines 0 comments Download
M src/svg/SkSVGDevice.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/svg/SkSVGDevice.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 4 chunks +4 lines, -6 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M src/utils/SkPaintFilterCanvas.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
reed1
5 years, 5 months ago (2015-07-17 19:02:58 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239193002/1
5 years, 5 months ago (2015-07-17 19:03:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-17 19:12:44 UTC) #6
djsollen
android got ToT merged in, is there anything holding this up anymore?
5 years, 4 months ago (2015-07-27 13:54:28 UTC) #7
reed1
just a-waiting on your approval
5 years, 4 months ago (2015-07-27 18:49:40 UTC) #8
djsollen
lgtm
5 years, 4 months ago (2015-07-28 12:19:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239193002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1239193002/1
5 years, 4 months ago (2015-07-28 12:59:41 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/2169) Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, ...
5 years, 4 months ago (2015-07-28 13:00:33 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1239193002/20001
5 years, 4 months ago (2015-07-28 14:27:37 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-07-28 14:35:18 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/562fe4767cc73e08a4e039362bc0336aea66ecfb

Powered by Google App Engine
This is Rietveld 408576698