Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 1239153002: Convert mojo_public_environment_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert mojo_public_environment_unittests to run exclusively on Swarming 0 configs already ran on Swarming 20 used to run locally and were converted: - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Android GN - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) Ran: ./manage.py --convert mojo_public_environment_unittests R=jam@chromium.org BUG=98637 Committed: https://crrev.com/6724b2c0c7bad2b303ca69dfecf23db9974d8e92 Cr-Commit-Position: refs/heads/master@{#339355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2 lines) Patch
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 4 chunks +12 lines, -0 lines 0 comments Download
M third_party/mojo/mojo_edk_tests.gyp View 1 chunk +13 lines, -0 lines 0 comments Download
A + third_party/mojo/mojo_public_environment_unittests.isolate View 1 chunk +2 lines, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (1 generated)
M-A Ruel
This time properly updating build/gn_migration.gypi. Only 2 tests left.
5 years, 5 months ago (2015-07-17 15:24:39 UTC) #1
jam
lgtm
5 years, 5 months ago (2015-07-17 15:35:24 UTC) #2
jam
On 2015/07/17 15:35:24, jam wrote: > lgtm btw i noticed in these changes you've been ...
5 years, 5 months ago (2015-07-17 15:36:13 UTC) #3
M-A Ruel
On 2015/07/17 15:36:13, jam wrote: > On 2015/07/17 15:35:24, jam wrote: > > lgtm > ...
5 years, 5 months ago (2015-07-17 22:17:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239153002/1
5 years, 5 months ago (2015-07-17 22:23:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-17 23:34:50 UTC) #7
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 23:35:57 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6724b2c0c7bad2b303ca69dfecf23db9974d8e92
Cr-Commit-Position: refs/heads/master@{#339355}

Powered by Google App Engine
This is Rietveld 408576698