runtime/vm/flow_graph_optimizer.cc - Issue 12391060: In LoadOptimizer::EmitPhis check for environment uses of phis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_optimizer.cc

Issue 12391060: In LoadOptimizer::EmitPhis check for environment uses of phis. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/flow_graph_optimizer.cc

diff --git a/runtime/vm/flow_graph_optimizer.cc b/runtime/vm/flow_graph_optimizer.cc

index d74c8643bc3d5445a1db3e98d5c10fb018473512..522dee1a22007fcaf82a884f584f21dff92470f9 100644

--- a/runtime/vm/flow_graph_optimizer.cc

+++ b/runtime/vm/flow_graph_optimizer.cc

@@ -3381,7 +3381,7 @@ class LoadOptimizer : public ValueObject {

void EmitPhis() {

for (intptr_t i = 0; i < phis_.length(); i++) {

PhiInstr* phi = phis_[i];

- if ((phi->input_use_list() != NULL) && !EliminateRedundantPhi(phi)) {

+ if (phi->HasUses() && !EliminateRedundantPhi(phi)) {

phi->mark_alive();

phi->block()->InsertPhi(phi);

} else {

« no previous file with comments | « no previous file | tests/language/store_to_load_forwarding_phis_vm_test.dart » ('j') | no next file with comments »