src/x64/lithium-codegen-x64.cc - Issue 12391055: Cleaned up CpuFeature scope handling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-codegen-x64.cc

Issue 12391055: Cleaned up CpuFeature scope handling. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: ARM and MIPS support Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-codegen-x64.cc

diff --git a/src/x64/lithium-codegen-x64.cc b/src/x64/lithium-codegen-x64.cc

index de47f6f4d1138011973e9e3ca45181c4f33302fd..5eb15b725bfd9a15ba11afa60e1c7a018317851f 100644

--- a/src/x64/lithium-codegen-x64.cc

+++ b/src/x64/lithium-codegen-x64.cc

@@ -3474,7 +3474,7 @@ void LCodeGen::DoMathFloor(LUnaryMathOperation* instr) {

XMMRegister input_reg = ToDoubleRegister(instr->value());

if (CpuFeatures::IsSupported(SSE4_1)) {

- CpuFeatures::Scope scope(SSE4_1);

+ CpuFeatureScope scope(masm(), SSE4_1);

if (instr->hydrogen()->CheckFlag(HValue::kBailoutOnMinusZero)) {

// Deoptimize if minus zero.

__ movq(output_reg, input_reg);