Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Side by Side Diff: src/ia32/code-stubs-ia32.h

Issue 12391033: Make sure that on x86 we don't generate SSE2 code in the snapshot. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: New method CpuFeatures::IsSafeForSnapshot(). Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
57 57
58 Major MajorKey() { return TranscendentalCache; } 58 Major MajorKey() { return TranscendentalCache; }
59 int MinorKey() { return type_ | argument_type_; } 59 int MinorKey() { return type_ | argument_type_; }
60 Runtime::FunctionId RuntimeFunction(); 60 Runtime::FunctionId RuntimeFunction();
61 }; 61 };
62 62
63 63
64 class StoreBufferOverflowStub: public PlatformCodeStub { 64 class StoreBufferOverflowStub: public PlatformCodeStub {
65 public: 65 public:
66 explicit StoreBufferOverflowStub(SaveFPRegsMode save_fp) 66 explicit StoreBufferOverflowStub(SaveFPRegsMode save_fp)
67 : save_doubles_(save_fp) { } 67 : save_doubles_(save_fp) {
68 ASSERT(CpuFeatures::IsSafeForSnapshot(SSE2) || save_fp == kDontSaveFPRegs);
69 }
68 70
69 void Generate(MacroAssembler* masm); 71 void Generate(MacroAssembler* masm);
70 72
71 virtual bool IsPregenerated() { return true; } 73 virtual bool IsPregenerated() { return true; }
72 static void GenerateFixedRegStubsAheadOfTime(Isolate* isolate); 74 static void GenerateFixedRegStubsAheadOfTime(Isolate* isolate);
73 virtual bool SometimesSetsUpAFrame() { return false; } 75 virtual bool SometimesSetsUpAFrame() { return false; }
74 76
75 private: 77 private:
76 SaveFPRegsMode save_doubles_; 78 SaveFPRegsMode save_doubles_;
77 79
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 RememberedSetAction remembered_set_action, 392 RememberedSetAction remembered_set_action,
391 SaveFPRegsMode fp_mode) 393 SaveFPRegsMode fp_mode)
392 : object_(object), 394 : object_(object),
393 value_(value), 395 value_(value),
394 address_(address), 396 address_(address),
395 remembered_set_action_(remembered_set_action), 397 remembered_set_action_(remembered_set_action),
396 save_fp_regs_mode_(fp_mode), 398 save_fp_regs_mode_(fp_mode),
397 regs_(object, // An input reg. 399 regs_(object, // An input reg.
398 address, // An input reg. 400 address, // An input reg.
399 value) { // One scratch reg. 401 value) { // One scratch reg.
402 ASSERT(CpuFeatures::IsSafeForSnapshot(SSE2) || fp_mode == kDontSaveFPRegs);
400 } 403 }
401 404
402 enum Mode { 405 enum Mode {
403 STORE_BUFFER_ONLY, 406 STORE_BUFFER_ONLY,
404 INCREMENTAL, 407 INCREMENTAL,
405 INCREMENTAL_COMPACTION 408 INCREMENTAL_COMPACTION
406 }; 409 };
407 410
408 virtual bool IsPregenerated(); 411 virtual bool IsPregenerated();
409 static void GenerateFixedRegStubsAheadOfTime(Isolate* isolate); 412 static void GenerateFixedRegStubsAheadOfTime(Isolate* isolate);
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
637 Register address_; 640 Register address_;
638 RememberedSetAction remembered_set_action_; 641 RememberedSetAction remembered_set_action_;
639 SaveFPRegsMode save_fp_regs_mode_; 642 SaveFPRegsMode save_fp_regs_mode_;
640 RegisterAllocation regs_; 643 RegisterAllocation regs_;
641 }; 644 };
642 645
643 646
644 } } // namespace v8::internal 647 } } // namespace v8::internal
645 648
646 #endif // V8_IA32_CODE_STUBS_IA32_H_ 649 #endif // V8_IA32_CODE_STUBS_IA32_H_
OLDNEW
« no previous file with comments | « src/ia32/builtins-ia32.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | src/isolate.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698