Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 12391033: Make sure that on x86 we don't generate SSE2 code in the snapshot. (Closed)

Created:
7 years, 9 months ago by mvstanton
Modified:
7 years, 9 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make sure that on x86 we don't generate SSE2 code in the snapshot. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13844

Patch Set 1 #

Patch Set 2 : Updates #

Patch Set 3 : Now rely on CpuFeatures::IsSupported() to work at snapshot time too. #

Patch Set 4 : New method CpuFeatures::IsSafeForSnapshot(). #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -108 lines) Patch
M src/arm/assembler-arm.h View 1 2 3 1 chunk +4 lines, -25 lines 0 comments Download
M src/arm/builtins-arm.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M src/assembler.cc View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M src/ia32/assembler-ia32.h View 1 2 3 1 chunk +4 lines, -25 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 3 2 chunks +2 lines, -6 lines 0 comments Download
M src/ia32/code-stubs-ia32.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 1 chunk +3 lines, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 6 chunks +11 lines, -5 lines 0 comments Download
M src/isolate.cc View 1 2 3 1 chunk +1 line, -0 lines 1 comment Download
M src/mips/assembler-mips.h View 1 2 3 1 chunk +0 lines, -26 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M src/x64/assembler-x64.h View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mvstanton
Hi Michael, Here is the change to make sure that we don't generate SSE/floating point ...
7 years, 9 months ago (2013-03-01 14:33:43 UTC) #1
mvstanton
Okay, this one is ready for a look, thanks!
7 years, 9 months ago (2013-03-01 17:10:17 UTC) #2
Sven Panne
General comment: I don't really like the tests for Serializer::Enabled() in this CL, although they ...
7 years, 9 months ago (2013-03-04 08:38:19 UTC) #3
mvstanton
Here is the updated CL. Sven, note that I removed the "force" feature test, just ...
7 years, 9 months ago (2013-03-06 09:32:42 UTC) #4
mvstanton
Hi Sven, hi Michael, I eliminated the TryForce classes and use the new IsSafeForSnapshot() predicate. ...
7 years, 9 months ago (2013-03-06 13:17:52 UTC) #5
Sven Panne
LGTM, but perhaps Michael should have at least a quick look, too, the state space ...
7 years, 9 months ago (2013-03-06 13:24:41 UTC) #6
Michael Starzinger
7 years, 9 months ago (2013-03-06 16:01:04 UTC) #7
LGTM as well, with one nit.

https://codereview.chromium.org/12391033/diff/10002/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/12391033/diff/10002/src/isolate.cc#newcode2159
src/isolate.cc:2159: // Ensure that the stub failure trampoline has been
generated.
The comment is outdated, this ensures that all stubs which need to be generated
ahead of time, but cannot be serialized into the snapshot have been generated.

Powered by Google App Engine
This is Rietveld 408576698