Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 1239103002: Fix visual bench memory leak (Closed)

Created:
5 years, 5 months ago by joshua.litt
Modified:
5 years, 5 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@fixvb1
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M tools/VisualBench/VisualBench.h View 1 chunk +1 line, -1 line 0 comments Download
M tools/VisualBench/VisualBench.cpp View 2 chunks +2 lines, -5 lines 0 comments Download
M tools/VisualBench/VisualBenchmarkStream.cpp View 1 2 chunks +4 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
joshualitt
ptal
5 years, 5 months ago (2015-07-16 20:49:09 UTC) #2
bsalomon
On 2015/07/16 20:49:09, joshualitt wrote: > ptal lgtm
5 years, 5 months ago (2015-07-16 21:13:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239103002/20001
5 years, 5 months ago (2015-07-16 21:15:30 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 21:23:25 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/47d280d3b0f3e271d29ffcffa061b5ad54f08b7e

Powered by Google App Engine
This is Rietveld 408576698