Sync FileSystem: Add simulated relaunch of DriveFileSyncService on its unit_tests

Sync FileSystem: Add  simulated relaunch of DriveFileSyncService on its unit_tests

This change contains:
 - Fetch remote change even when we have pending changes,
 - Add simulated relaunch of services to new test framework,
 - Bugfix on testing,

BUG=176900
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185838

[tzik, 2013-02-28 13:33:50]

PTAL

[kinuko, 2013-02-28 13:58:30]

lgtm

https://codereview.chromium.org/12391012/diff/2001/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc
(right):

https://codereview.chromium.org/12391012/diff/2001/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc:85: };
Not used?

https://codereview.chromium.org/12391012/diff/2001/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/fake_remote_change_processor.cc (right):

https://codereview.chromium.org/12391012/diff/2001/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/fake_remote_change_processor.cc:39: }
It's ok for this change, but maybe we should rather maintain a map or something
to simulate the local fs image (i.e. maintain the in-memory map based on the
changes applied by ApplyRemoteChange)? That'll make it easier for further
changes.

[tzik, 2013-02-28 14:00:38]

Thanks! Updated.

https://codereview.chromium.org/12391012/diff/2001/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc
(right):

https://codereview.chromium.org/12391012/diff/2001/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/drive_file_sync_service_sync_unittest.cc:85: };
On 2013/02/28 13:58:30, kinuko wrote:
> Not used?

Done.

https://codereview.chromium.org/12391012/diff/2001/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/fake_remote_change_processor.cc (right):

https://codereview.chromium.org/12391012/diff/2001/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/fake_remote_change_processor.cc:39: }
On 2013/02/28 13:58:30, kinuko wrote:
> It's ok for this change, but maybe we should rather maintain a map or
something
> to simulate the local fs image (i.e. maintain the in-memory map based on the
> changes applied by ApplyRemoteChange)? That'll make it easier for further
> changes.

OK, I'll do it next patch.

[nhiroki, 2013-03-01 03:25:21]

lgtm

https://codereview.chromium.org/12391012/diff/7002/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/drive_file_sync_service.h (right):

https://codereview.chromium.org/12391012/diff/7002/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/drive_file_sync_service.h:65: // Destroy
|sync_service| and pass the ownership of |sync_client| to caller
nit: Destroy->Destroys, pass->passes

[tzik, 2013-03-01 03:43:01]

https://codereview.chromium.org/12391012/diff/7002/chrome/browser/sync_file_s...
File chrome/browser/sync_file_system/drive_file_sync_service.h (right):

https://codereview.chromium.org/12391012/diff/7002/chrome/browser/sync_file_s...
chrome/browser/sync_file_system/drive_file_sync_service.h:65: // Destroy
|sync_service| and pass the ownership of |sync_client| to caller
On 2013/03/01 03:25:21, nhiroki wrote:
> nit: Destroy->Destroys, pass->passes

Done.

[commit-bot: I haz the power, 2013-03-01 03:43:38]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/12391012/8003

[commit-bot: I haz the power, 2013-03-01 05:22:40]

Retried try job too often on win_rel for step(s) browser_tests,
content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-03-01 05:29:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/12391012/8003

[commit-bot: I haz the power, 2013-03-01 08:55:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/12391012/8003

[commit-bot: I haz the power, 2013-03-01 10:30:05]

Retried try job too often on win7_aura for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-03-04 03:40:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tzik@chromium.org/12391012/20001

[commit-bot: I haz the power, 2013-03-04 05:56:48]

Change committed as 185838