Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1239083005: Revert of Replace system IO calls in chromecast/crash with Chrome utilities. (Closed)

Created:
5 years, 5 months ago by dcaiafa
Modified:
5 years, 5 months ago
CC:
chromium-reviews, kalyank, lcwu+watch_chromium.org, sadrul, gunsch+watch_chromium.org, gfhuang
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Replace system IO calls in chromecast/crash with Chrome utilities. (patchset #9 id:160001 of https://codereview.chromium.org/1227963002/) Reason for revert: Breaks CastCrashReporterClientTest.EndToEndTestOnIORestrictedThread: https://build.chromium.org/p/chromium.linux/builders/Cast%20Linux/builds/2709 Original issue's description: > Replace system IO calls in chromecast/crash with Chrome utilities. > > System IO calls had been used to avoid thread IO restrictions in the > crash handler. This change replaces each of these calls with the more > platform-independent, stable Chrome IO utilities from ::base. Thread > restrictions are disabled in crash_util.cc. > > BUG= b/22329428 > > Committed: https://crrev.com/4927df40d0342522fc268f884835b43f9004549e > Cr-Commit-Position: refs/heads/master@{#339161} TBR=wzhong@chromium.org,bcf@google.com,gunsch@chromium.org,gfhuang@chromium.org,slan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= b/22329428 Committed: https://crrev.com/4306386450441c312f0e94af12074ae1534b4117 Cr-Commit-Position: refs/heads/master@{#339183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -131 lines) Patch
M chromecast/app/linux/cast_crash_reporter_client_unittest.cc View 2 chunks +55 lines, -95 lines 0 comments Download
M chromecast/crash/linux/crash_util.cc View 3 chunks +8 lines, -13 lines 0 comments Download
M chromecast/crash/linux/dummy_minidump_generator.h View 1 chunk +13 lines, -3 lines 0 comments Download
M chromecast/crash/linux/dummy_minidump_generator.cc View 2 chunks +73 lines, -7 lines 0 comments Download
M chromecast/crash/linux/dummy_minidump_generator_unittest.cc View 3 chunks +85 lines, -5 lines 0 comments Download
M chromecast/crash/linux/minidump_generator.h View 1 chunk +2 lines, -5 lines 0 comments Download
M chromecast/crash/linux/synchronized_minidump_manager.cc View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcaiafa
Created Revert of Replace system IO calls in chromecast/crash with Chrome utilities.
5 years, 5 months ago (2015-07-17 00:06:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239083005/1
5 years, 5 months ago (2015-07-17 00:07:34 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-17 00:10:04 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4306386450441c312f0e94af12074ae1534b4117 Cr-Commit-Position: refs/heads/master@{#339183}
5 years, 5 months ago (2015-07-17 00:11:36 UTC) #4
slan
5 years, 5 months ago (2015-07-17 16:37:36 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1240843003/ by slan@chromium.org.

The reason for reverting is: The offending test case shall be guarded with
ENABLE_THREAD_RESTRICTIONS..

Powered by Google App Engine
This is Rietveld 408576698