Issue 1239073002: Revert of Give GrBatch a pointer to GrPipeline

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1239073002: Revert of Give GrBatch a pointer to GrPipeline (Closed)

Created:
5 years, 5 months ago by joshualitt

Modified:
5 years, 5 months ago

Reviewers:
bsalomon, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

Revert of Give GrBatch a pointer to GrPipeline (patchset #1 id:1 of https://codereview.chromium.org/1237283007/) Reason for revert: breaking nanobench Original issue's description: > Give GrBatch a pointer to GrPipeline > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/1170a12839218f7a23c93487bf95fd83aae0201f TBR=bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0df62e3d685f6b0b61ee514c68006e013109f5a1

Created: 5 years, 5 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -20 lines)			Patch
M	gm/beziereffects.cpp	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	gm/convexpolyeffect.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/gpu/GrBatch.h	View	7 chunks	+8 lines, -13 lines	0 comments	Download
M	src/gpu/GrPipeline.h	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/gpu/GrReorderCommandBuilder.cpp	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

joshualitt

Created Revert of Give GrBatch a pointer to GrPipeline

5 years, 5 months ago (2015-07-16 14:16:38 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1239073002/1

5 years, 5 months ago (2015-07-16 14:16:49 UTC) #2

commit-bot: I haz the power

5 years, 5 months ago (2015-07-16 14:16:56 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0df62e3d685f6b0b61ee514c68006e013109f5a1