extensions/browser/extension_function_histogram_value.h - Issue 1239043002: Add support for actions for multiple file selection.

Side by Side Diff: extensions/browser/extension_function_histogram_value.h

Issue 1239043002: Add support for actions for multiple file selection. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed externs. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/test/data/extensions/api_test/file_system_provider/get_actions/test.js ('k') | third_party/closure_compiler/externs/file_manager_private.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef EXTENSIONS_BROWSER_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_	5 #ifndef EXTENSIONS_BROWSER_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_

6 #define EXTENSIONS_BROWSER_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_	6 #define EXTENSIONS_BROWSER_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_

7	7

8 namespace extensions {	8 namespace extensions {

9 namespace functions {	9 namespace functions {

10	10

(...skipping 1102 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
1113 WEBCAMPRIVATE_CLOSEWEBCAM,	1113 WEBCAMPRIVATE_CLOSEWEBCAM,

1114 SERIAL_SETBREAK,	1114 SERIAL_SETBREAK,

1115 SERIAL_CLEARBREAK,	1115 SERIAL_CLEARBREAK,

1116 EXTENSIONVIEWINTERNAL_LOADSRC,	1116 EXTENSIONVIEWINTERNAL_LOADSRC,

1117 EXTENSIONVIEWINTERNAL_PARSESRC,	1117 EXTENSIONVIEWINTERNAL_PARSESRC,

1118 HID_GETUSERSELECTEDDEVICES,	1118 HID_GETUSERSELECTEDDEVICES,

1119 FILESYSTEMPROVIDERINTERNAL_GETACTIONSREQUESTEDSUCCESS,	1119 FILESYSTEMPROVIDERINTERNAL_GETACTIONSREQUESTEDSUCCESS,

1120 DASHBOARDPRIVATE_SHOWPERMISSIONPROMPTFORDELEGATEDBUNDLEINSTALL,	1120 DASHBOARDPRIVATE_SHOWPERMISSIONPROMPTFORDELEGATEDBUNDLEINSTALL,

1121 FILEMANAGERPRIVATEINTERNAL_GETENTRYACTIONS,	1121 FILEMANAGERPRIVATEINTERNAL_GETENTRYACTIONS,

1122 FILEMANAGERPRIVATEINTERNAL_EXECUTEENTRYACTION,	1122 FILEMANAGERPRIVATEINTERNAL_EXECUTEENTRYACTION,

	1123 FILEMANAGERPRIVATEINTERNAL_GETCUSTOMACTIONS,

	1124 FILEMANAGERPRIVATEINTERNAL_EXECUTECUSTOMACTION,
	Ilya Sherman 2015/10/16 19:49:49 Yikes, I did not notice that you added entries to Yikes, I did not notice that you added entries to the middle of this enum. Please never do that. By doing so, you've shifted the numeric values backing the other entries in the enum, and have thereby made the metrics for those incorrect. Please only ever update the histograms.xml file entry for this enum by running the appropriate script -- that would have made this error more obvious. mtomasz 2015/10/16 23:40:54 Oops. This is a rebase error. As you can see, the Show quoted text On 2015/10/16 19:49:49, Ilya Sherman wrote: > Yikes, I did not notice that you added entries to the middle of this enum. > Please never do that. By doing so, you've shifted the numeric values backing > the other entries in the enum, and have thereby made the metrics for those > incorrect. Please only ever update the histograms.xml file entry for this enum > by running the appropriate script -- that would have made this error more > obvious. Oops. This is a rebase error. As you can see, the entires are duplicated. I never add entries in the middle. Sorry for that. I'm now OOO. I can fix it on Monday.
1123 MDNS_FORCEDISCOVERY,	1125 MDNS_FORCEDISCOVERY,

1124 LANGUAGESETTINGSPRIVATE_GETLANGUAGELIST,	1126 LANGUAGESETTINGSPRIVATE_GETLANGUAGELIST,

1125 LANGUAGESETTINGSPRIVATE_SETLANGUAGELIST,	1127 LANGUAGESETTINGSPRIVATE_SETLANGUAGELIST,

1126 LANGUAGESETTINGSPRIVATE_GETSPELLCHECKDICTIONARYSTATUS,	1128 LANGUAGESETTINGSPRIVATE_GETSPELLCHECKDICTIONARYSTATUS,

1127 LANGUAGESETTINGSPRIVATE_GETSPELLCHECKWORDS,	1129 LANGUAGESETTINGSPRIVATE_GETSPELLCHECKWORDS,

1128 LANGUAGESETTINGSPRIVATE_GETTRANSLATETARGETLANGUAGE,	1130 LANGUAGESETTINGSPRIVATE_GETTRANSLATETARGETLANGUAGE,

1129 LANGUAGESETTINGSPRIVATE_GETINPUTMETHODLISTS,	1131 LANGUAGESETTINGSPRIVATE_GETINPUTMETHODLISTS,

1130 LANGUAGESETTINGSPRIVATE_ADDINPUTMETHOD,	1132 LANGUAGESETTINGSPRIVATE_ADDINPUTMETHOD,

1131 LANGUAGESETTINGSPRIVATE_REMOVEINPUTMETHOD,	1133 LANGUAGESETTINGSPRIVATE_REMOVEINPUTMETHOD,

1132 FILEMANAGERPRIVATE_CANCELALLFILETRANSFERS,	1134 FILEMANAGERPRIVATE_CANCELALLFILETRANSFERS,

(...skipping 10 matching lines...) Expand all Loading...
1143 BLUETOOTHPRIVATE_PAIR,	1145 BLUETOOTHPRIVATE_PAIR,

1144 // Last entry: Add new entries above, then run:	1146 // Last entry: Add new entries above, then run:

1145 // python tools/metrics/histograms/update_extension_histograms.py	1147 // python tools/metrics/histograms/update_extension_histograms.py

1146 ENUM_BOUNDARY	1148 ENUM_BOUNDARY

1147 };	1149 };

1148	1150

1149 } // namespace functions	1151 } // namespace functions

1150 } // namespace extensions	1152 } // namespace extensions

1151	1153

1152 #endif // EXTENSIONS_BROWSER_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_	1154 #endif // EXTENSIONS_BROWSER_EXTENSION_FUNCTION_HISTOGRAM_VALUE_H_

OLD	NEW