Debugger: use FrameInspector in ScopeIterator to find context.

Debugger: use FrameInspector in ScopeIterator to find context.

In optimized code, it's not guaranteed that the current context
is stored in its frame slot.

R=bmeurer@chromium.org
BUG=v8:4309
LOG=N

Committed: https://crrev.com/3a0ee39cbde6a9778cfc4e2a6a0a8ff68933ff38
Cr-Commit-Position: refs/heads/master@{#29697}

Committed: https://crrev.com/01902e4eabc45d4f04ce644117b2bf552493dcb2
Cr-Commit-Position: refs/heads/master@{#29744}

[Yang, 2015-07-16 07:18:08]

On 2015/07/16 07:17:06, Yang wrote:

The ScopeIterator code is a mess. This CL is to fix a bug. I will however submit
a clean up to put the ScopeIterator into a separate file and clean it up, later.

[Benedikt Meurer, 2015-07-16 07:33:40]

LGTM with nit (mostly rubber-stamped).

https://codereview.chromium.org/1239033002/diff/1/src/runtime/runtime-debug.cc
File src/runtime/runtime-debug.cc (right):

https://codereview.chromium.org/1239033002/diff/1/src/runtime/runtime-debug.c...
src/runtime/runtime-debug.cc:1741: FrameInspector* frame_inspector_;
Nit: Make this const, i.e. FrameInspector* const frame_inspector_;

[Benedikt Meurer, 2015-07-16 08:27:58]

Still LGTM.

[Yang, 2015-07-16 08:28:36]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2015-07-16 08:28:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239033002/20001

[commit-bot: I haz the power, 2015-07-16 08:38:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-16 08:38:51]

Try jobs failed on following builders:
  v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/7716)

(exceeded global retry quota)

[Yang, 2015-07-16 09:04:49]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-07-16 09:04:50]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1239033002/#ps40001
(title: "update test expectation")

[commit-bot: I haz the power, 2015-07-16 09:05:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239033002/40001

[commit-bot: I haz the power, 2015-07-16 09:28:18]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-07-16 09:28:32]

Patchset 3 (id:??) landed as
https://crrev.com/3a0ee39cbde6a9778cfc4e2a6a0a8ff68933ff38
Cr-Commit-Position: refs/heads/master@{#29697}

[Yang, 2015-07-17 09:53:28]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1243553002/ by yangguo@chromium.org.

The reason for reverting is: breaks roll:
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_....

[Yang, 2015-07-20 08:22:51]

Patchset #5 (id:80001) has been deleted

[Yang, 2015-07-20 08:23:28]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2015-07-20 08:23:28]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/1239033002/#ps60001
(title: "fix")

[commit-bot: I haz the power, 2015-07-20 08:23:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1239033002/60001

[commit-bot: I haz the power, 2015-07-20 08:53:26]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-07-20 08:53:49]

Patchset 4 (id:??) landed as
https://crrev.com/01902e4eabc45d4f04ce644117b2bf552493dcb2
Cr-Commit-Position: refs/heads/master@{#29744}