Issue 12390081: Set landmine to clobber android trybots.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12390081: Set landmine to clobber android trybots. (Closed)

Created:
7 years, 9 months ago by Isaac (away)

Modified:
7 years, 9 months ago

Reviewers:
iannucci, gone

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Set landmine to clobber android trybots. Fixing findbugs errors from incremental builds. BUG=180079 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186053

Patch Set 1 #

Patch Set 2 : ] #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/landmines.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

Committed patchset #2 manually as r186053 (presubmit successful).

7 years, 9 months ago (2013-03-05 01:43:28 UTC) #3

iannucci

7 years, 9 months ago (2013-03-05 01:44:53 UTC) #4

Message was sent while issue was closed.

On 2013/03/05 01:41:03, dfalcantara wrote:
> On 2013/03/05 01:38:59, Isaac wrote:
> 
> LGTM

LGTM, though I'm not sure what the etiquette should be around replacing existing
landmines instead of adding new ones.

Expand Messages | Collapse Messages