Android: Support GPU process

Android: Support GPU process

This supports running the GPU thread in its own process outside the browser (which is really the default mode).

This changes the browser compositor API to pass a Java Surface instead of ANativeWindow. (Needed to pass the surface handle over to the other process).
It implements a synchronous API from the GPU thread to the browser to retrieve the surface, which is safe since this ends up on a binder thread different from the main thread.

This is enabled by removing kInProcessGpu from content_startup_flags.cc

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186606

[no sievers, 2013-03-05 00:32:33]

Hi Marcus,

this top is based on top of the surface cruft removal, and adds some code to be
able to run the GPU process (you'd have to remove kInProcessGpu from the
hardcoded command line), which is really mainly a matter of getting the surface
handle to the other process.

I wanted to get this (default) mode working again.

https://codereview.chromium.org/12390077/diff/1/content/browser/android/sandb...
File content/browser/android/sandboxed_process_launcher.cc (right):

https://codereview.chromium.org/12390077/diff/1/content/browser/android/sandb...
content/browser/android/sandboxed_process_launcher.cc:60: }
I guess I should really share this code with SurfaceTexturePeerBrowserImpl.

[bulach, 2013-03-05 14:23:57]

lgtm for the android/jni bits, but it'd be nice to add some pair of eyes from
the gpu team, I can't say I'm terribly familiar with this.. :)

just nits from my side:

https://codereview.chromium.org/12390077/diff/1/content/app/android/sandboxed...
File content/app/android/sandboxed_process_service.cc (right):

https://codereview.chromium.org/12390077/diff/1/content/app/android/sandboxed...
content/app/android/sandboxed_process_service.cc:36:
SurfaceTexturePeerSandboxedImpl(
nit: explicit

https://codereview.chromium.org/12390077/diff/1/content/app/android/sandboxed...
content/app/android/sandboxed_process_service.cc:65: CheckException(env);
nit: all generated Java_ methods call "CheckException" internally (unless it's
marked as @CalledByNativeUnchecked)..

https://codereview.chromium.org/12390077/diff/1/content/browser/android/sandb...
File content/browser/android/sandboxed_process_launcher.cc (right):

https://codereview.chromium.org/12390077/diff/1/content/browser/android/sandb...
content/browser/android/sandboxed_process_launcher.cc:62: }  // anonymous
namespace
nit: add a \n

https://codereview.chromium.org/12390077/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
(right):

https://codereview.chromium.org/12390077/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java:21:
import org.chromium.content.common.CommandLine;
nit: seems unused..

https://codereview.chromium.org/12390077/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java:37:
}
enums in java are normally frowned upon (one of those long, lengthy
discussions)... since this is private anyways, probably best to stay away and
just use static final ints..

https://codereview.chromium.org/12390077/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java:217:
if (Arrays.asList(commandLine).contains("--type=renderer")) {
unroll this:

List<String> commandLineList = Arrays.asList(commandLine);

[no sievers, 2013-03-05 21:44:17]

+Al for gpu-related stuff.

[no sievers, 2013-03-05 21:47:02]

https://codereview.chromium.org/12390077/diff/1/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (right):

https://codereview.chromium.org/12390077/diff/1/ui/gl/gl_surface_egl.cc#newco...
ui/gl/gl_surface_egl.cc:227: if (window)
The extra ref is for NativeViewGLSurfaceEGL::Resize() which destroys the EGL
surface which releases all references to the underlying graphics buffer.
Currently with kInProcessGpu we hold an extra reference through the browser
compositor, but that does not hold up when the surface is used in another
process.

[apatrick_chromium, 2013-03-05 22:52:16]

ui/gl lgtm

[no sievers, 2013-03-07 00:51:06]

https://codereview.chromium.org/12390077/diff/1/content/app/android/sandboxed...
File content/app/android/sandboxed_process_service.cc (right):

https://codereview.chromium.org/12390077/diff/1/content/app/android/sandboxed...
content/app/android/sandboxed_process_service.cc:36:
SurfaceTexturePeerSandboxedImpl(
On 2013/03/05 14:23:58, bulach wrote:
> nit: explicit

Done.

https://codereview.chromium.org/12390077/diff/1/content/app/android/sandboxed...
content/app/android/sandboxed_process_service.cc:65: CheckException(env);
On 2013/03/05 14:23:58, bulach wrote:
> nit: all generated Java_ methods call "CheckException" internally (unless it's
> marked as @CalledByNativeUnchecked)..

Done.

https://codereview.chromium.org/12390077/diff/1/content/browser/android/sandb...
File content/browser/android/sandboxed_process_launcher.cc (right):

https://codereview.chromium.org/12390077/diff/1/content/browser/android/sandb...
content/browser/android/sandboxed_process_launcher.cc:62: }  // anonymous
namespace
On 2013/03/05 14:23:58, bulach wrote:
> nit: add a \n

Done.

https://codereview.chromium.org/12390077/diff/1/content/public/android/java/s...
File
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
(right):

https://codereview.chromium.org/12390077/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java:37:
}
On 2013/03/05 14:23:58, bulach wrote:
> enums in java are normally frowned upon (one of those long, lengthy
> discussions)... since this is private anyways, probably best to stay away and
> just use static final ints..

Done.

https://codereview.chromium.org/12390077/diff/1/content/public/android/java/s...
content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java:217:
if (Arrays.asList(commandLine).contains("--type=renderer")) {
On 2013/03/05 14:23:58, bulach wrote:
> unroll this:
> 
> List<String> commandLineList = Arrays.asList(commandLine);

Done.

[commit-bot: I haz the power, 2013-03-07 00:51:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sievers@chromium.org/12390077/11001

[commit-bot: I haz the power, 2013-03-07 03:58:21]

Change committed as 186606