Attaching a DOM Activity Logger to all extension scripts

chrome/renderer/extensions/dom_activity_logger.h

Index: chrome/renderer/extensions/dom_activity_logger.h
===================================================================
--- chrome/renderer/extensions/dom_activity_logger.h	(revision 0)
+++ chrome/renderer/extensions/dom_activity_logger.h	(revision 0)
@@ -0,0 +1,49 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.

[Matt Perry, 2013/03/05 02:32:37]

2013

[Ankur Taly, 2013/03/05 20:03:32]

Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_RENDERER_EXTENSIONS_DOM_ACTIVITY_LOGGER_H_
+#define CHROME_RENDERER_EXTENSIONS_DOM_ACTIVITY_LOGGER_H_
+
+#include "base/string_piece.h"
+#include "googleurl/src/gurl.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebDOMActivityLogger.h"
+#include "v8/include/v8.h"
+
+namespace extensions {
+
+class DOMActivityLogger: public WebKit::WebDOMActivityLogger {
+ public:
+  static const int kMainWorldId = 0;
+  DOMActivityLogger(std::string extension_id,
+                    GURL url,
+                    string16 title);

[Matt Perry, 2013/03/05 02:32:37]

pass these all by const ref

[Ankur Taly, 2013/03/05 20:03:32]

Done.

+
+  // Marshalls the arguments into an ExtensionHostMsg_DOMAction_Params
+  // and sends it over to the browser (via IPC) for appending it to the
+  // extension activity log.
+  virtual void log(const char* api_name,

[Matt Perry, 2013/03/05 02:32:37]

This is chrome code, so use chrome style naming (e.g. Log).

[Ankur Taly, 2013/03/05 20:03:32]

This method is supposed to override the "log" method in
WebKit::WebDOMActivityLogger and therefore follows the WebKit convention. I put
in a comment saying this.

On 2013/03/05 02:32:37, Matt Perry wrote:

[Matt Perry, 2013/03/05 20:34:22]

Oops, I missed that this class overrode a WebKit API.

On 2013/03/05 20:03:32, ataly1 wrote:

+                   int argc,
+                   const v8::Handle<v8::Value> args[],
+                   const char* extra_info);

[Matt Perry, 2013/03/05 02:32:37]

also, use std::string instead of const char*

[Ankur Taly, 2013/03/05 20:03:32]

This would require changing the "log" method declaration in WebKit. My plan is
to change the log method arguments to be of type WebString, from which I can
then extract std::string values and send them over to the activity log. 
On 2013/03/05 02:32:37, Matt Perry wrote:

+
+  // If extension activity logging is enabled then check (using the
+  // WebKit API) if there is no logger attached to the world corresponding
+  // to world_id, and if so, construct a new logger and attach it.
+  // worl_id = 0 indicates the main world.
+  static void attachToWorld(int world_id,
+                            std::string extension_id,
+                            GURL url,
+                            string16 title);

[Matt Perry, 2013/03/05 02:32:37]

const ref

[Ankur Taly, 2013/03/05 20:03:32]

Done.

+
+ private:
+  std::string extension_id_;
+  GURL url_;
+  string16 title_;
+
+  DISALLOW_COPY_AND_ASSIGN(DOMActivityLogger);
+};
+
+} // namespace extensions
+
+#endif  // CHROME_RENDERER_EXTENSIONS_DOM_ACTIVITY_LOGGER_H_
Property changes on: chrome/renderer/extensions/dom_activity_logger.h
___________________________________________________________________
Added: svn:eol-style
   + LF