Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1336)

Issue 12390064: Merge 144196 (Closed)

Created:
7 years, 9 months ago by Justin Novosad
Modified:
7 years, 9 months ago
Reviewers:
junov1
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 144196 > REGRESSION (r134631) of border-radius percentage with border pixel > https://bugs.webkit.org/show_bug.cgi?id=110889 > > Reviewed by Simon Fraser. > > Source/WebCore: > > Fixing background color filling to handle "non renderable" rounded > rectangles. > > Test: fast/borders/border-radius-percent.html > > * rendering/RenderBoxModelObject.cpp: > (WebCore::RenderBoxModelObject::paintFillLayerExtended): > > LayoutTests: > > Adding new pixel test to verify the correct rendering of > rounded rectangle backgrounds with inner border radii that > exceed the dimensions of the inner edge of the border. > > * fast/borders/border-radius-percent-expected.txt: Added. > * fast/borders/border-radius-percent.html: Added. > * platform/chromium-linux/fast/borders/border-radius-percent-expected.png: Added. > * platform/chromium/TestExpectations: > TBR=junov@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144665

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, --2 lines) Patch
A + LayoutTests/fast/borders/border-radius-percent.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/fast/borders/border-radius-percent-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/platform/chromium-linux/fast/borders/border-radius-percent-expected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/rendering/RenderBoxModelObject.cpp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
Justin Novosad
7 years, 9 months ago (2013-03-04 21:35:54 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698