Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 12390060: RdpDesktopSession COM class should only use raw interfaces. (Closed)

Created:
7 years, 9 months ago by alexeypa (please no reviews)
Modified:
7 years, 9 months ago
Reviewers:
Jamie, dcaiafa
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

RdpDesktopSession COM class should only use raw interfaces. The daemon has to provide an implementation of IRdpDesktopSessionEventHandler interface in order to receive events from RdpDesktopSession. It is currently a dual interface (inherited from IDispatch) which either makes the implementation more complex than necessary or makes the daemon to depend on ATL. Switching to raw interfaces allows to both simplify the implementation and avoid ATL dependency. This CL makes remoting_core.dll a proxy/stub DLL used to marshall the raw interfaces that the host defines. BUG=137696 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186280

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -22 lines) Patch
M remoting/host/installer/win/chromoting.wxs View 1 2 3 4 chunks +41 lines, -14 lines 0 comments Download
M remoting/host/win/chromoting_lib_idl.templ View 2 chunks +2 lines, -4 lines 0 comments Download
M remoting/host/win/core.cc View 1 chunk +7 lines, -1 line 0 comments Download
M remoting/host/win/rdp_desktop_session.h View 2 chunks +2 lines, -3 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
alexeypa (please no reviews)
PTAL.
7 years, 9 months ago (2013-03-04 17:25:05 UTC) #1
Jamie
Looks fine as far as I understand what it's doing, but this is far outside ...
7 years, 9 months ago (2013-03-04 17:50:49 UTC) #2
dcaiafa
lgtm
7 years, 9 months ago (2013-03-05 18:12:31 UTC) #3
Jamie
Rubber-stamp LGTM.
7 years, 9 months ago (2013-03-05 19:48:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/12390060/11001
7 years, 9 months ago (2013-03-05 20:00:32 UTC) #5
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-05 20:08:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/12390060/11001
7 years, 9 months ago (2013-03-05 20:31:42 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/12390060/21003
7 years, 9 months ago (2013-03-05 20:45:14 UTC) #8
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 9 months ago (2013-03-05 20:51:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alexeypa@chromium.org/12390060/31001
7 years, 9 months ago (2013-03-05 23:11:38 UTC) #10
alexeypa (please no reviews)
7 years, 9 months ago (2013-03-05 23:17:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 manually as r186280 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698