Issue 12390052: gtk/bookmarks: Display bookmark folder icon on Bookmarks menu.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12390052: gtk/bookmarks: Display bookmark folder icon on Bookmarks menu. (Closed)

Created:
7 years, 9 months ago by tfarina

Modified:
7 years, 9 months ago

Reviewers:
Elliot Glaysher

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gtk/bookmarks: Display bookmark folder icon on Bookmarks menu. BUG=172594 TEST= 1- launch chrome 2- bookmark some folders on bookmarks bar either through bookmarks bar or bookmark manager. 3- go to wrench (hotdogs) menu -> bookmarks menu. 4- now you should see the bookmark folder icon for folders as well. R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186189

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	chrome/browser/ui/gtk/bookmarks/bookmark_sub_menu_model_gtk.cc	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed manually as r186189 (presubmit successful).

Expand Messages | Collapse Messages