views: Migrate ash_shell buttons to LabelButton

views: Migrate ash_shell buttons to LabelButton

BUG=155363
R=msw@chromium.org
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185819

[tfarina, 2013-03-03 03:01:13]

Please, take a look.

[msw, 2013-03-03 04:38:35]

LGTM with a minor change; also, this shouldn't have appearance changes even with
--enable-new-dialog-style, so strike that part of the note from your CL
description.

https://codereview.chromium.org/12390049/diff/1/ash/shell/window_type_launche...
File ash/shell/window_type_launcher.cc (right):

https://codereview.chromium.org/12390049/diff/1/ash/shell/window_type_launche...
ash/shell/window_type_launcher.cc:56: new views::LabelButton(this,
ASCIIToUTF16("Moar!")))) {
You need to set the native style on this button.

[tfarina, 2013-03-03 21:38:26]

On 2013/03/03 04:38:35, msw wrote:
> LGTM with a minor change; also, this shouldn't have appearance changes even
with
> --enable-new-dialog-style, so strike that part of the note from your CL
> description.
> 
Done.

Also TBRing Scott as the changes are straightforward.

https://codereview.chromium.org/12390049/diff/1/ash/shell/window_type_launche...
File ash/shell/window_type_launcher.cc (right):

https://codereview.chromium.org/12390049/diff/1/ash/shell/window_type_launche...
ash/shell/window_type_launcher.cc:56: new views::LabelButton(this,
ASCIIToUTF16("Moar!")))) {
On 2013/03/03 04:38:36, msw wrote:
> You need to set the native style on this button.

Done.

[commit-bot: I haz the power, 2013-03-03 21:39:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/12390049/4002

[commit-bot: I haz the power, 2013-03-04 00:31:01]

Change committed as 185819