Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Unified Diff: ui/gl/generate_bindings.py

Issue 12390032: Revert 185518 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/khronos/README.chromium ('k') | ui/gl/gl_bindings_skia_in_process.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gl/generate_bindings.py
===================================================================
--- ui/gl/generate_bindings.py (revision 185518)
+++ ui/gl/generate_bindings.py (working copy)
@@ -482,7 +482,7 @@
{ 'return_type': 'void',
'names': ['glShaderSource'],
'arguments':
- 'GLuint shader, GLsizei count, const char** str, const GLint* length',
+ 'GLuint shader, GLsizei count, const char* const* str, const GLint* length',
'logging_code': """
GL_SERVICE_LOG_CODE_BLOCK({
for (GLsizei ii = 0; ii < count; ++ii) {
@@ -1584,7 +1584,7 @@
file.write('\n')
file.write('%s GL_BINDING_CALL Mock_%s(%s) {\n' %
(func['return_type'], func['names'][0], func['arguments']))
- argument_names = re.sub(r'(const )?[a-zA-Z0-9]+\** ([a-zA-Z0-9]+)', r'\2',
+ argument_names = re.sub(r'(const )?[a-zA-Z0-9]+((\s*const\s*)?\*)* ([a-zA-Z0-9]+)', r'\4',
func['arguments'])
if argument_names == 'void':
argument_names = ''
« no previous file with comments | « third_party/khronos/README.chromium ('k') | ui/gl/gl_bindings_skia_in_process.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698