Issue 12390021: Move the default definition of GR_USE_NEW_SHADER_SOURCE_SIGNATURE to GrGLConfig.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12390021: Move the default definition of GR_USE_NEW_SHADER_SOURCE_SIGNATURE to GrGLConfig. (Closed)

Created:
7 years, 9 months ago by bsalomon

Modified:
7 years, 9 months ago

Reviewers:
Stephen White, robertphillips, senorblanco

CC:
skia-review_googlegroups.com, Paweł Hajdan Jr.

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

Move the default definition of GR_USE_NEW_SHADER_SOURCE_SIGNATURE to GrGLConfig. R=senorblanco@google.com Committed: https://code.google.com/p/skia/source/detail?r=7904

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -15 lines)			Patch
M	include/gpu/GrConfig.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
M	include/gpu/gl/GrGLConfig.h	View		2 chunks	+8 lines, -0 lines	0 comments	Download
M	include/gpu/gl/GrGLConfig_chrome.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	include/gpu/gl/GrGLFunctions.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLNoOpInterface.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/GrGLNoOpInterface.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/android/GrGLCreateNativeInterface_android.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/gpu/gl/mac/GrGLCreateNativeInterface_mac.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

bsalomon

This makes the macro a bit more consistent with our other GL-specific macros both in ...

7 years, 9 months ago (2013-02-28 19:11:30 UTC) #1

bsalomon

On 2013/02/28 19:22:19, Stephen White wrote: > Makes sense. LGTM Thanks, Stephen. I should have ...

7 years, 9 months ago (2013-02-28 19:24:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r7904.