Issue 12390007: Merge 184833

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12390007: Merge 184833 (Closed)

Created:
7 years, 9 months ago by koz (OOO until 15th September)

Modified:
7 years, 9 months ago

Reviewers:
koz (OOO until 15th September)

CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1410/src/

Visibility:
Public.

Merge 184833 > Apps that don't appear on the NTP shouldn't contribute to NTP page overflow. > > > BUG=175377 > TEST=Start chrome with a fresh profile (eg: --user-data-dir=new-dir), then keep installing apps from the Chrome Web Store until you have 18. All 18 apps should appear on the same (first) page. > > Review URL: https://chromiumcodereview.appspot.com/12331003 TBR=koz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185173

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+41 lines, -11 lines)			Patch
M	chrome/browser/extensions/extension_service.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_sorting.h	View	4 chunks	+21 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extension_sorting.cc	View	3 chunks	+16 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

koz (OOO until 15th September)

7 years, 9 months ago (2013-02-28 07:07:08 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r185173.