Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 1238973009: Revert of Version 4.4.63.20 (cherry-pick) (Closed)

Created:
5 years, 5 months ago by Michael Hablich
Modified:
5 years, 5 months ago
CC:
v8-dev, Paweł Hajdan Jr., ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@4.4
Target Ref:
refs/pending/branch-heads/4.4
Project:
v8
Visibility:
Public.

Description

Revert of Version 4.4.63.20 (cherry-pick) (patchset #1 id:1 of https://codereview.chromium.org/1233413003/) Reason for revert: Reverting because it resulted in errors on the bots: http://build.chromium.org/p/client.v8.branches/builders/V8%20arm%20-%20sim%20-%20stable%20branch/builds/78/steps/Check/logs/stdio Jacob, can you have a look please? It seems a merge back to 4.4 is not that straight-forward. Original issue's description: > Version 4.4.63.20 (cherry-pick) > > Merged 6802c4b921fdc717227fec996e6988ff12a93c1b > Merged d05538827e32ebfed5297653266d65c11e438148 > Merged 879550ce0f8d3cffb519440101a4026635bc6026 > Merged 3c9c7748c386d967762116de53e31dd1d24f8627 > > [arm] Remove unused jump_elimination_allowed parameter to Assembler::branch_offset(). > > [arm] Fix missing CheckBuffer for branches. > > [arm] Don't call branch_offset within CheckConstPool. > > [arm] CheckConstPool between TurboFan instructions. > > Conflicts resolved by manual patch > > BUG=v8:4292, chromium:509666 > LOG=N > R=bmeurer@chromium.org, jacob.bramley@arm.com > > Committed: https://chromium.googlesource.com/v8/v8/+/15508c765bf761b7eee990c46f41446f0c241db2 TBR=bmeurer@chromium.org,jacob.bramley@arm.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4292, chromium:509666

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -96 lines) Patch
M include/v8-version.h View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/assembler-arm.h View 3 chunks +8 lines, -13 lines 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +9 lines, -20 lines 0 comments Download
M src/arm/assembler-arm-inl.h View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/test-assembler-arm.cc View 1 chunk +0 lines, -59 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Hablich
Created Revert of Version 4.4.63.20 (cherry-pick)
5 years, 5 months ago (2015-07-17 13:55:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238973009/1
5 years, 5 months ago (2015-07-17 13:55:19 UTC) #2
commit-bot: I haz the power
5 years, 5 months ago (2015-07-17 13:55:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698