Issue 12389075: Bugfix: allow handle dereference only when we have a valid hydrogen graph or lithium chunk.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12389075: Bugfix: allow handle dereference only when we have a valid hydrogen graph or lithium chunk. (Closed)

Created:
7 years, 9 months ago by mvstanton

Modified:
7 years, 9 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Bugfix: allow handle dereference only when we have a valid hydrogen graph or lithium chunk. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13793

Patch Set 1 #

Patch Set 2 : Fix trailing whitespace #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	src/hydrogen.cc	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mvstanton

Hi Yang, When tracing hydrogen stubs there is a case when the graph is NULL. ...

7 years, 9 months ago (2013-03-04 12:31:41 UTC) #1

Yang

7 years, 9 months ago (2013-03-04 12:33:19 UTC) #2

On 2013/03/04 12:31:41, mvstanton wrote:
> Hi Yang,
> When tracing hydrogen stubs there is a case when the graph is NULL. I need to
> place the handle dereference statement one level deeper.
> Thanks for having a look!
> --Michael

LGTM.

Expand Messages | Collapse Messages