Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 12389075: Bugfix: allow handle dereference only when we have a valid hydrogen graph or lithium chunk. (Closed)

Created:
7 years, 9 months ago by mvstanton
Modified:
7 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

Bugfix: allow handle dereference only when we have a valid hydrogen graph or lithium chunk. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13793

Patch Set 1 #

Patch Set 2 : Fix trailing whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/hydrogen.cc View 1 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
mvstanton
Hi Yang, When tracing hydrogen stubs there is a case when the graph is NULL. ...
7 years, 9 months ago (2013-03-04 12:31:41 UTC) #1
Yang
7 years, 9 months ago (2013-03-04 12:33:19 UTC) #2
On 2013/03/04 12:31:41, mvstanton wrote:
> Hi Yang,
> When tracing hydrogen stubs there is a case when the graph is NULL. I need to
> place the handle dereference statement one level deeper.
> Thanks for having a look!
> --Michael

LGTM.

Powered by Google App Engine
This is Rietveld 408576698