Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1338)

Unified Diff: sdk/lib/_internal/compiler/implementation/closure.dart

Issue 12389046: Re-apply: Inside a generative constructor, "this" is created at the very end. So we have to use the… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/closure.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/closure.dart (revision 19293)
+++ sdk/lib/_internal/compiler/implementation/closure.dart (working copy)
@@ -447,11 +447,10 @@
}
if (outermostElement.isMember() &&
compiler.world.needsRti(outermostElement.getEnclosingClass())) {
- if (outermostElement.isInstanceMember()
- || outermostElement.isGenerativeConstructor()) {
- if (hasTypeVariable(type)) useLocal(closureData.thisElement);
- } else if (outermostElement.isFactoryConstructor()) {
+ if (outermostElement.isConstructor()) {
analyzeTypeVariables(type);
+ } else if (outermostElement.isInstanceMember()) {
+ if (hasTypeVariable(type)) useLocal(closureData.thisElement);
}
}
« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/ssa/builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698