Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 12389044: Merge 144161 (Closed)

Created:
7 years, 9 months ago by eustas
Modified:
7 years, 9 months ago
Reviewers:
eustas
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1410/
Visibility:
Public.

Description

Merge 144161 > Web Inspector: timeline stops working on certain sites > https://bugs.webkit.org/show_bug.cgi?id=110955 > > Reviewed by Alexander Pavlov. > > Analysis: "timerId" value is number, > so it is not wrapped to node as expected. > > Solution: wrap values of all types except Node. > > * inspector/front-end/TimelinePresentationModel.js: > Wrap nonstring values to text nodes. > TBR=eustas@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144418

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -4 lines) Patch
M Source/WebCore/ChangeLog View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/WebCore/inspector/front-end/TimelinePresentationModel.js View 2 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eustas
7 years, 9 months ago (2013-03-01 06:21:37 UTC) #1
eustas
7 years, 9 months ago (2013-03-01 06:21:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r144418.

Powered by Google App Engine
This is Rietveld 408576698