Issue 1238903002: Fix performance regression introduced in r29558

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1238903002: Fix performance regression introduced in r29558 (Closed)

Created:
5 years, 5 months ago by Jakob Kummerow

Modified:
5 years, 5 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Fix performance regression introduced in r29558 where bound functions started overriding the "name" accessor property with a data property. The bootstrapper must be kept in sync to avoid polymorphism. BUG=chromium:509983 LOG=n R=verwaest@chromium.org Committed: https://crrev.com/597af29260161ec3d11d5ec2f2383b8f9a4a040f Cr-Commit-Position: refs/heads/master@{#29685}

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -16 lines)			Patch
	M	src/bootstrapper.cc	View		1 chunk	+24 lines, -16 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238903002/1

5 years, 5 months ago (2015-07-15 15:04:57 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-15 15:56:36 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/597af29260161ec3d11d5ec2f2383b8f9a4a040f
Cr-Commit-Position: refs/heads/master@{#29685}