sdk/lib/_internal/compiler/implementation/enqueue.dart - Issue 12389025: Do not register typechecks against type variables of typedefs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/enqueue.dart

Issue 12389025: Do not register typechecks against type variables of typedefs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Change inCheckContext for typedef contexts. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('j') | sdk/lib/_internal/compiler/implementation/resolution/members.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/enqueue.dart

diff --git a/sdk/lib/_internal/compiler/implementation/enqueue.dart b/sdk/lib/_internal/compiler/implementation/enqueue.dart

index acf846242ac4f9f16e459199f907fa3f0f9d001a..57574a08b0d0d90ac21f2dfa1484c32b2679be6f 100644

--- a/sdk/lib/_internal/compiler/implementation/enqueue.dart

+++ b/sdk/lib/_internal/compiler/implementation/enqueue.dart

@@ -356,6 +356,8 @@ abstract class Enqueuer {

}

void registerIsCheck(DartType type) {

+ assert(type.kind != TypeKind.TYPE_VARIABLE ||

+ !type.element.enclosingElement.isTypedef());

universe.isChecks.add(type);

compiler.backend.registerIsCheck(type, this);

}