Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: sdk/lib/_internal/compiler/implementation/enqueue.dart

Issue 12389025: Do not register typechecks against type variables of typedefs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/enqueue.dart
diff --git a/sdk/lib/_internal/compiler/implementation/enqueue.dart b/sdk/lib/_internal/compiler/implementation/enqueue.dart
index acf846242ac4f9f16e459199f907fa3f0f9d001a..10b858f1e1a1b9945583f2510c5db394e997f220 100644
--- a/sdk/lib/_internal/compiler/implementation/enqueue.dart
+++ b/sdk/lib/_internal/compiler/implementation/enqueue.dart
@@ -356,8 +356,12 @@ abstract class Enqueuer {
}
void registerIsCheck(DartType type) {
- universe.isChecks.add(type);
- compiler.backend.registerIsCheck(type, this);
+ // Do not register checks against type-variables of typedefs.
ngeoffray 2013/02/28 16:56:19 I'd prefer if you could do that in the resolver in
karlklose 2013/02/28 17:16:45 Done.
+ if (type.kind != TypeKind.TYPE_VARIABLE ||
+ type.element.isTypedef()) {
+ universe.isChecks.add(type);
+ compiler.backend.registerIsCheck(type, this);
+ }
}
void registerAsCheck(DartType type) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698