Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 12389023: Revert 144194 (Closed)

Created:
7 years, 9 months ago by karen
Modified:
7 years, 9 months ago
Reviewers:
haraken
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1425/
Visibility:
Public.

Description

Revert 144194 > [V8] Generate a wrapper function for ReplaceableAttrSetter() > https://bugs.webkit.org/show_bug.cgi?id=110781 > > Reviewed by Adam Barth. > > This is one of steps to insert TRACE_EVENT_STATE() macros > into DOM bindings. This patch introduces an indirection function > for xxxReplaceableAttrSetter(), like this: > > // For non-custom replaceable setters (Note: One implementation > is enough for all replaceable setters in one interface.) > void V8XXX:::ReplaceableAttrSetterCallback(...) { > V8XXX::ReplaceableAttrSetter(...); > } > > // For custom replaceable setters. (Note: This is treated as > a normal custom setter.) > void xxxAttrSetterCallback(...) { > return xxxAttrSetterCustom(...); > } > > No tests. No change in behavior. > > * bindings/scripts/CodeGeneratorV8.pm: > (GenerateReplaceableAttrSetterCallback): > (GenerateReplaceableAttrSetter): > (GenerateSingleBatchedAttribute): > (GenerateImplementation): > * bindings/scripts/test/V8/V8TestObj.cpp: > (WebCore::TestObjV8Internal::TestObjReplaceableAttrSetterCallback): > (TestObjV8Internal): > (WebCore): > * bindings/scripts/test/V8/V8TestTypedefs.cpp: > (WebCore::TestTypedefsV8Internal::TestTypedefsReplaceableAttrSetterCallback): > (TestTypedefsV8Internal): TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=144312

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -29 lines) Patch
M Source/WebCore/bindings/scripts/CodeGeneratorV8.pm View 4 chunks +4 lines, -15 lines 0 comments Download
M Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp View 3 chunks +4 lines, -9 lines 0 comments Download
M Source/WebCore/bindings/scripts/test/V8/V8TestTypedefs.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
karen
7 years, 9 months ago (2013-02-28 15:23:01 UTC) #1
karen
7 years, 9 months ago (2013-02-28 15:23:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r144312.

Powered by Google App Engine
This is Rietveld 408576698