Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 123883002: Fix PrintingControllerTest#testNormalPrintingFlow and reenable the test (Closed)

Created:
6 years, 11 months ago by cimamoglu (inactive)
Modified:
6 years, 11 months ago
Reviewers:
whywhat, bulach
CC:
chromium-reviews, navabi1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix PrintingControllerTest#testNormalPrintingFlow and reenable the test Moves the creation of PrintingControllerImpl into the UI thread. Before, it wasn't being created in the UI thread, and for some reason PrintingControllerImpl#create wasn't failing its UI thread assertion. It did start to fail for N4 with KitKat, so this fixes the issue and re-enables the test. BUG=330291 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243850

Patch Set 1 #

Patch Set 2 : Remove redundant imports #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -21 lines) Patch
chrome/android/javatests/src/org/chromium/chrome/browser/printing/PrintingControllerTest.java View 1 3 chunks +37 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
cimamoglu (inactive)
6 years, 11 months ago (2014-01-03 14:40:25 UTC) #1
whywhat
lgtm
6 years, 11 months ago (2014-01-07 15:02:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cimamoglu@chromium.org/123883002/1
6 years, 11 months ago (2014-01-07 15:04:11 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43512
6 years, 11 months ago (2014-01-07 15:23:05 UTC) #4
cimamoglu (inactive)
bulach@chromium.org: Please review changes in For OWNERS
6 years, 11 months ago (2014-01-07 16:39:52 UTC) #5
bulach
lgtm, thanks!
6 years, 11 months ago (2014-01-08 16:04:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cimamoglu@chromium.org/123883002/1
6 years, 11 months ago (2014-01-08 16:06:13 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=43807
6 years, 11 months ago (2014-01-08 16:29:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cimamoglu@chromium.org/123883002/250001
6 years, 11 months ago (2014-01-08 16:34:53 UTC) #9
commit-bot: I haz the power
Retried try job too often on android_clang_dbg for step(s) slave_steps http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_clang_dbg&number=105376
6 years, 11 months ago (2014-01-09 02:43:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cimamoglu@chromium.org/123883002/250001
6 years, 11 months ago (2014-01-09 11:29:04 UTC) #11
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 11:51:07 UTC) #12
Message was sent while issue was closed.
Change committed as 243850

Powered by Google App Engine
This is Rietveld 408576698