Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 12388099: [SPDY] Add flag to turn on SPDY/3.1 (with per-session flow control) (Closed)

Created:
7 years, 9 months ago by akalin
Modified:
7 years, 9 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

[SPDY] Add flag to turn on SPDY/3.1 (with per-session flow control) Add SPDY/3.1 info for NPN and Alternate-Protocol. BUG=176592 TBR=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=186250

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -17 lines) Patch
M chrome/browser/io_thread.cc View 1 chunk +5 lines, -9 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/http/http_network_transaction_spdy3_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/http_server_properties.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_server_properties.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/http/http_stream_factory.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/http/http_stream_factory.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M net/socket/next_proto.h View 1 chunk +4 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M net/socket/ssl_client_socket_pool.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M net/spdy/spdy_network_transaction_spdy3_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
akalin
+rch for review
7 years, 9 months ago (2013-03-05 00:19:32 UTC) #1
Ryan Hamilton
lgtm lgtm That being said, there's another yak to shave here. I've moved many of ...
7 years, 9 months ago (2013-03-05 17:28:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/12388099/1
7 years, 9 months ago (2013-03-05 19:58:44 UTC) #3
commit-bot: I haz the power
Presubmit check for 12388099-1 failed and returned exit status 1. INFO:root:Found 12 file(s). Running presubmit ...
7 years, 9 months ago (2013-03-05 19:58:49 UTC) #4
akalin
TBRing jam@ for io_thread.cc
7 years, 9 months ago (2013-03-05 20:45:44 UTC) #5
akalin
Committed patchset #1 manually as r186250 (presubmit successful).
7 years, 9 months ago (2013-03-05 20:48:04 UTC) #6
akalin
7 years, 9 months ago (2013-03-05 22:07:02 UTC) #7
Message was sent while issue was closed.
On 2013/03/05 17:28:08, Ryan Hamilton wrote:
> lgtm
> 
> lgtm
> 
> That being said, there's another yak to shave here.  I've moved many of the
> statics in net to per-instance members which come in via
> HttpNetworkSession::Params.  We really should do this for the remaining few,
> among which are the lists of enabled protocols.  You can add this to your list
> of places to shave :>

Okay! Added that yak to the queue.

Powered by Google App Engine
This is Rietveld 408576698