third_party/tcmalloc/chromium/src/heap-checker.cc - Issue 12388070: Count m(un)map for each stacktrace in MemoryRegionMap instead of HeapProfileTable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/tcmalloc/chromium/src/heap-checker.cc

Issue 12388070: Count m(un)map for each stacktrace in MemoryRegionMap instead of HeapProfileTable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed willchan's comments Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/tcmalloc/chromium/src/deep-heap-profile.cc ('k') | third_party/tcmalloc/chromium/src/heap-profile-stats.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/tcmalloc/chromium/src/heap-checker.cc

diff --git a/third_party/tcmalloc/chromium/src/heap-checker.cc b/third_party/tcmalloc/chromium/src/heap-checker.cc

index c53646b43ccc31d6e8c5470cd83ff91ca5d95548..ae69c7b971d255c6e69cab9adefd407a0ddfaedd 100644

--- a/third_party/tcmalloc/chromium/src/heap-checker.cc

+++ b/third_party/tcmalloc/chromium/src/heap-checker.cc

@@ -2203,7 +2203,7 @@ void HeapLeakChecker::BeforeConstructorsLocked() {

RAW_CHECK(MallocHook::AddNewHook(&NewHook), "");

RAW_CHECK(MallocHook::AddDeleteHook(&DeleteHook), "");

constructor_heap_profiling = true;

- MemoryRegionMap::Init(1);

+ MemoryRegionMap::Init(1, /* use_buckets */ false);

// Set up MemoryRegionMap with (at least) one caller stack frame to record

// (important that it's done before HeapProfileTable creation below).

Allocator::Init();

« no previous file with comments | « third_party/tcmalloc/chromium/src/deep-heap-profile.cc ('k') | third_party/tcmalloc/chromium/src/heap-profile-stats.h » ('j') | no next file with comments »