third_party/tcmalloc/chromium/src/heap-profile-stats.h - Issue 12388070: Count m(un)map for each stacktrace in MemoryRegionMap instead of HeapProfileTable.

Side by Side Diff: third_party/tcmalloc/chromium/src/heap-profile-stats.h

Issue 12388070: Count m(un)map for each stacktrace in MemoryRegionMap instead of HeapProfileTable. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added comments for functions Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« third_party/tcmalloc/chromium/src/deep-heap-profile.cc ('K') | « third_party/tcmalloc/chromium/src/heap-checker.cc ('k') | third_party/tcmalloc/chromium/src/heap-profile-table.h » ('j') | third_party/tcmalloc/chromium/src/heap-profile-table.h » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // This file defines structs to accumulate memory allocation and deallocation

	6 // counts. These structs are commonly used for malloc (in HeapProfileTable)

	7 // and mmap (in MemoryRegionMap).

	8

	9 #ifndef HEAP_PROFILE_STATS_H_

	10 #define HEAP_PROFILE_STATS_H_

	11

	12 struct HeapProfileStats {

	13 // Returns true if the two HeapProfileStats are semantically equal.

	14 bool Equivalent(const HeapProfileStats& x) const {
	jar (doing other things) 2013/03/08 04:43:31 nit: avoid use of one letter variables. Suggest " nit: avoid use of one letter variables. Suggest "other" rather than "x". Dai Mikurube (NOT FULLTIME) 2013/03/12 08:24:10 Ok, done. It was just a move from HeapProfileTabl Show quoted text On 2013/03/08 04:43:31, jar wrote: > nit: avoid use of one letter variables. Suggest "other" rather than "x". Ok, done. It was just a move from HeapProfileTable::Stats.
	15 return allocs - frees == x.allocs - x.frees &&

	16 alloc_size - free_size == x.alloc_size - x.free_size;
	jar (doing other things) 2013/03/08 04:43:31 nit: indent 4 nit: indent 4 Dai Mikurube (NOT FULLTIME) 2013/03/12 08:24:10 Done. Show quoted text On 2013/03/08 04:43:31, jar wrote: > nit: indent 4 Done.
	17 }

	18

	19 int32 allocs; // Number of allocation calls.

	20 int32 frees; // Number of free calls.
	jar (doing other things) 2013/03/08 04:43:31 Why aren't these unsigned? What is the meaning af Why aren't these unsigned? What is the meaning after overflows? Dai Mikurube (NOT FULLTIME) 2013/03/12 08:24:10 As I wrote above, it's just a move from the existi Show quoted text On 2013/03/08 04:43:31, jar wrote: > Why aren't these unsigned? What is the meaning after overflows? As I wrote above, it's just a move from the existing HeapProfileTable::Stats. I'm not sure of the perfect historical reason, but I think we should keep the types.
	21 int64 alloc_size; // Total size of all allocated objects so far.

	22 int64 free_size; // Total size of all freed objects so far.

	23 };

	24

	25 // Allocation and deallocation statistics per each stack trace.

	26 struct HeapProfileBucket : public HeapProfileStats {

	27 // Longest stack trace we record.

	28 static const int kMaxStackDepth = 32;
	jar (doing other things) 2013/03/08 04:43:31 Is the intiialization of a static inside a class l Is the intiialization of a static inside a class legal on all our compilers? Dai Mikurube (NOT FULLTIME) 2013/03/12 08:24:10 It works for static and const variables. We have Show quoted text On 2013/03/08 04:43:31, jar wrote: > Is the intiialization of a static inside a class legal on all our compilers? It works for static and const variables. We have such initialization for a very long time. I heard that it actually fails in a very old compiler "Visual C++ 6.0", but we should blame the compiler in this case. It's allowed in the C++03. http://stackoverflow.com/questions/2605520/c-where-to-initialize-static-const http://www.devx.com/tips/Tip/5602 http://chanduthedev.blogspot.jp/2012/02/how-to-initialize-const-variable-in-c... I'm interested in a document that says they're wrong. Also, these are examples used in the Chromium tree. (There are more in V8.) http://src.chromium.org/viewvc/chrome/trunk/src/base/lazy_instance.h?view=markup http://src.chromium.org/viewvc/chrome/trunk/src/base/time.h?view=markup http://src.chromium.org/viewvc/chrome/trunk/src/base/metrics/stats_table.h?vi... http://src.chromium.org/viewvc/chrome/trunk/src/courgette/ensemble.h?view=markup http://src.chromium.org/viewvc/chrome/trunk/src/net/quic/quic_http_stream_tes...
	29

	30 uintptr_t hash; // Hash value of the stack trace.

	31 int depth; // Depth of stack trace.

	32 const void** stack; // Stack trace.

	33 HeapProfileBucket* next; // Next entry in hash-table.

	34 };

	35

	36 #endif // HEAP_PROFILE_STATS_H_

OLD	NEW