Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 12388060: fix building with glibc-2.16+ (Closed)

Created:
7 years, 9 months ago by vapier
Modified:
7 years, 9 months ago
CC:
chromium-reviews, Markus (顧孟勤)
Visibility:
Public.

Description

Fix building with glibc-2.16+ Upstream glibc dropped 'struct siginfo' and now there is only 'siginfo_t'. This fix comes from the gperftools project: https://code.google.com/p/gperftools/source/detail?r=176 Committed: https://code.google.com/p/linux-syscall-support/source/detail?r=18

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M lss/linux_syscall_support.h View 3 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vapier
7 years, 9 months ago (2013-03-02 09:25:08 UTC) #1
Mark Seaborn
LGTM
7 years, 9 months ago (2013-03-02 15:26:58 UTC) #2
vapier
so, how do i actually commit this now ? :) i tried clicking "commit", but ...
7 years, 9 months ago (2013-03-05 04:27:38 UTC) #3
Mark Seaborn
On 4 March 2013 20:27, <vapier@chromium.org> wrote: > so, how do i actually commit this ...
7 years, 9 months ago (2013-03-05 16:37:52 UTC) #4
vapier
ok, so trybots passed and i think i committed it correctly: https://code.google.com/p/linux-syscall-support/source/detail?r=18 i posted https://codereview.chromium.org/12523002/ ...
7 years, 9 months ago (2013-03-06 04:31:33 UTC) #5
Mark Seaborn
On 2013/03/06 04:31:33, vapier wrote: > what should i do with this CL now ? ...
7 years, 9 months ago (2013-03-06 18:59:57 UTC) #6
vapier
7 years, 9 months ago (2013-03-06 19:10:50 UTC) #7
not that i recall.  but i've closed the window already.  i'll use the closed
button manually.

Powered by Google App Engine
This is Rietveld 408576698