Use base::MessageLoopProxy instead of MessageLoop* in webkit/media/.

Use base::MessageLoopProxy instead of MessageLoop* in webkit/media/.

Minor cleanup split off into a separate CL while working on bug 177730.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185400

[scherkus (not reviewing), 2013-03-01 00:44:00]

https://codereview.chromium.org/12388039/diff/1/webkit/media/webmediaplayer_i...
File webkit/media/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/12388039/diff/1/webkit/media/webmediaplayer_i...
webkit/media/webmediaplayer_impl.cc:220: if (MessageLoop::current())
this is NULL after WillDestroyCurrentMessageLoop() is called; see
~MessageLoop():
https://code.google.com/searchframe#OAMlx_jo-ck/src/base/message_loop.cc&exac...

[DaleCurtis, 2013-03-01 01:36:08]

lgtm % nits.

https://codereview.chromium.org/12388039/diff/5001/webkit/media/buffered_data...
File webkit/media/buffered_data_source.h (right):

https://codereview.chromium.org/12388039/diff/5001/webkit/media/buffered_data...
webkit/media/buffered_data_source.h:184: scoped_refptr<base::MessageLoopProxy>
render_loop_;
const since it can't change.

https://codereview.chromium.org/12388039/diff/5001/webkit/media/buffered_data...
File webkit/media/buffered_data_source_unittest.cc (right):

https://codereview.chromium.org/12388039/diff/5001/webkit/media/buffered_data...
webkit/media/buffered_data_source_unittest.cc:41: const
scoped_refptr<base::MessageLoopProxy> message_loop, WebFrame* frame)
&

https://codereview.chromium.org/12388039/diff/5001/webkit/media/webmediaplaye...
File webkit/media/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/12388039/diff/5001/webkit/media/webmediaplaye...
webkit/media/webmediaplayer_impl.cc:218: // Remove descrution observer if we're
being destroyed but the main thread is
destruction.

https://codereview.chromium.org/12388039/diff/5001/webkit/media/webmediaplaye...
File webkit/media/webmediaplayer_impl.h (right):

https://codereview.chromium.org/12388039/diff/5001/webkit/media/webmediaplaye...
webkit/media/webmediaplayer_impl.h:56: #include "base/message_loop.h"
Cleanup header?

https://codereview.chromium.org/12388039/diff/5001/webkit/media/webmediaplaye...
webkit/media/webmediaplayer_impl.h:291: scoped_refptr<base::MessageLoopProxy>
main_loop_;
const.

[scherkus (not reviewing), 2013-03-01 01:53:15]

thanks!

https://codereview.chromium.org/12388039/diff/5001/webkit/media/buffered_data...
File webkit/media/buffered_data_source.h (right):

https://codereview.chromium.org/12388039/diff/5001/webkit/media/buffered_data...
webkit/media/buffered_data_source.h:184: scoped_refptr<base::MessageLoopProxy>
render_loop_;
On 2013/03/01 01:36:08, DaleCurtis wrote:
> const since it can't change.

Done.

https://codereview.chromium.org/12388039/diff/5001/webkit/media/buffered_data...
File webkit/media/buffered_data_source_unittest.cc (right):

https://codereview.chromium.org/12388039/diff/5001/webkit/media/buffered_data...
webkit/media/buffered_data_source_unittest.cc:41: const
scoped_refptr<base::MessageLoopProxy> message_loop, WebFrame* frame)
On 2013/03/01 01:36:08, DaleCurtis wrote:
> &

Done.

https://codereview.chromium.org/12388039/diff/5001/webkit/media/webmediaplaye...
File webkit/media/webmediaplayer_impl.cc (right):

https://codereview.chromium.org/12388039/diff/5001/webkit/media/webmediaplaye...
webkit/media/webmediaplayer_impl.cc:218: // Remove descrution observer if we're
being destroyed but the main thread is
On 2013/03/01 01:36:08, DaleCurtis wrote:
> destruction.

Done.

https://codereview.chromium.org/12388039/diff/5001/webkit/media/webmediaplaye...
File webkit/media/webmediaplayer_impl.h (right):

https://codereview.chromium.org/12388039/diff/5001/webkit/media/webmediaplaye...
webkit/media/webmediaplayer_impl.h:56: #include "base/message_loop.h"
On 2013/03/01 01:36:08, DaleCurtis wrote:
> Cleanup header?

Done.

https://codereview.chromium.org/12388039/diff/5001/webkit/media/webmediaplaye...
webkit/media/webmediaplayer_impl.h:291: scoped_refptr<base::MessageLoopProxy>
main_loop_;
On 2013/03/01 01:36:08, DaleCurtis wrote:
> const.

Done.

[scherkus (not reviewing), 2013-03-01 01:54:35]

Committed patchset #3 manually as r185400 (presubmit successful).