Android: Remove Surface cruft

content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java

Index: content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java b/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
index 766eca3685197598e27c702d233ef6ccabd57a2f..fc1575418f89bca168fa39169d43a1ba5bdbafa2 100644
--- a/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
+++ b/content/public/android/java/src/org/chromium/content/browser/SandboxedProcessLauncher.java
@@ -262,24 +262,6 @@ public class SandboxedProcessLauncher {
         connection.unbindHighPriority(false);
     }
 
-    static void establishSurfacePeer(
-            int pid, int type, Surface surface, int primaryID, int secondaryID) {
-        Log.d(TAG, "establishSurfaceTexturePeer: pid = " + pid + ", " +
-              "type = " + type + ", " +
-              "primaryID = " + primaryID + ", " +
-              "secondaryID = " + secondaryID);
-        ISandboxedProcessService service = SandboxedProcessLauncher.getSandboxedService(pid);
-        if (service == null) {
-            Log.e(TAG, "Unable to get SandboxedProcessService from pid.");
-            return;
-        }
-        try {
-            service.setSurface(type, surface, primaryID, secondaryID);
-        } catch (RemoteException e) {
-            Log.e(TAG, "Unable to call setSurface: " + e);
-        }
-    }
-
     /**
      * This implementation is used to receive callbacks from the remote service.
      */
@@ -294,14 +276,8 @@ public class SandboxedProcessLauncher {
              */
             public void establishSurfacePeer(
                     int pid, int type, Surface surface, int primaryID, int secondaryID) {
-                SandboxedProcessLauncher.establishSurfacePeer(pid, type, surface,
-                        primaryID, secondaryID);
-                // The SandboxProcessService now holds a reference to the
-                // Surface's resources, so we release our reference to it now to
-                // avoid waiting for the finalizer to get around to it.
-                if (surface != null) {
-                    surface.release();
-                }
+                // TODO(sievers): This should call into native and pass the Surface to the
+                // right media player instance.

[no sievers, 2013/03/01 00:18:33]

I should explain this further.

The old path was supporting bouncing a Surface from a GPU child process through
here (browser) and on to a renderer child (where it is passed to MediaPlayer).
That is unused since the MediaPlayer moved from the renderer into the browser.

However, what should happen here is that we pass the Surface coming from the GPU
process here to the MediaPlayer in this (browser process). Currently we only
support this with the GPU thread running in the browser (where it goes through
SurfaceTexturePeerBrowserImpl).

             }
         };
     };