Android: Remove Surface cruft

content/common/android/scoped_java_surface.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_COMMON_ANDROID_SCOPED_JAVA_SURFACE_H_
+#define CONTENT_COMMON_ANDROID_SCOPED_JAVA_SURFACE_H_
+
+#include <jni.h>
+
+#include "base/android/scoped_java_ref.h"
+
+namespace content {
+
+class SurfaceTextureBridge;
+
+// A helper class for holding a scoped reference to a Java Surface instance.
+// When going out of scope, release() is called on the Java object to make

[bulach, 2013/03/05 10:32:33]

nit: to be extra clear, "Surface.release() is called..."

[no sievers, 2013/03/05 21:21:46]

Done.

+// sure server-side references (esp. wrt graphics memory) are released.
+class ScopedJavaSurface {
+ public:
+  ScopedJavaSurface();
+
+  // Wraps an existing Java Surface object in a ScopedJavaSurface.
+  explicit ScopedJavaSurface(const base::android::JavaRef<jobject>& surface);

[bulach, 2013/03/05 10:32:33]

the thing about "ResetFrom*" is that we could potentially have
"ResetFromJavaFoo" and "ResetFromJavaBar" and so on, all taking a
base::android::JavaRef<jobject>... this is not possible by just overriding the
constructor..


but yeah, since there doesn't seem to be any other way to create Surface anyway,
leave as is... :)

+
+  // Creates a Java Surface from a SurfaceTexture and wraps it in a
+  // ScopedJavaSurface.
+  explicit ScopedJavaSurface(const SurfaceTextureBridge* surface_texture);
+
+  ~ScopedJavaSurface();
+
+  const base::android::JavaRef<jobject>& j_surface() const {
+    return j_surface_;
+  }
+
+ private:
+  base::android::ScopedJavaGlobalRef<jobject> j_surface_;
+};
+
+}  // namespace content
+
+#endif  // CONTENT_COMMON_ANDROID_SCOPED_JAVA_SURFACE_H_