Android: Remove Surface cruft

content/browser/android/surface_texture_peer_browser_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/android/surface_texture_peer_browser_impl.h"
 
+#include "base/android/jni_android.h"
+#include "base/android/scoped_java_ref.h"
 #include "content/browser/android/media_player_manager_android.h"
 #include "content/browser/renderer_host/render_view_host_impl.h"
-#include "content/common/android/surface_callback.h"
+#include "content/common/android/surface.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/render_process_host.h"
-#include "jni/BrowserProcessSurfaceTexture_jni.h"
 #include "media/base/android/media_player_bridge.h"
 
 using base::android::MethodID;
 
 namespace content {
 
 // Pass a java surface object to the MediaPlayerBridge object
 // identified by render process handle, render view ID and player ID.
 static void SetSurfacePeer(
     scoped_refptr<SurfaceTextureBridge> surface_texture_bridge,
@@ skipping 16 matching lines @@
     RenderViewHostImpl* host = RenderViewHostImpl::FromID(
         renderer_id, render_view_id);
     if (host) {
       media::MediaPlayerBridge* player =
           host->media_player_manager()->GetPlayer(player_id);
       if (player &&
           player != host->media_player_manager()->GetFullscreenPlayer()) {
         base::android::ScopedJavaLocalRef<jclass> cls(
             base::android::GetClass(env, "android/view/Surface"));
         jmethodID constructor = MethodID::Get<MethodID::TYPE_INSTANCE>(
             env, cls.obj(), "<init>", "(Landroid/graphics/SurfaceTexture;)V");

[bulach, 2013/03/01 11:38:24]

yay, let's remove *all* the cruft! :)

it seems to me MediaPlayerBridge* in SetVideoSurface @ 55 has already a JNI up
to MediaPlayerBridge.java..

so, let's remove all this block 47-56 here, and just:
player->SetVideoSurfaceTexture(surface_texture_bridge->j_surface_texture().obj())

in media_player_bridge.cc, change SetVideoSurface to SetVideoSurfaceTexture,
then rather than calling JNI_MediaPlayer::setSurface, call:

Java_MediaPlayerBridget_setSurfaceTexture(...)

in the java side, have a static method in MediaPlayerBridge.java passing the
media player and this surface_text object, like:

@CalledByNative
private static void setVideoSurfaceTexture(MediaPlayer player, SurfaceTexture
surface_texture) {
  Surface surface = new Surface(surface_texture);
  player.setSurface(surface);
}


wdyt?

[no sievers, 2013/03/01 22:29:12]

Thanks for pointing out this block, I should have read the code here a little
closer. Yea this should all go too, but what about this: This is basically all
the JNI (creating a Surface from SurfaceTexture) that I already added in this
patch, so I can just create a local Surface object here. That way it doesn't
narrow down the MediaPlayerBridge interface (a Surface is a more generic type
and it can also be passed across process boundaries, while SurfaceTexture
cannot).

-        ScopedJavaLocalRef<jobject> j_surface(
+        base::android::ScopedJavaLocalRef<jobject> j_surface(
             env, env->NewObject(
                 cls.obj(), constructor,
                 surface_texture_bridge->j_surface_texture().obj()));
         player->SetVideoSurface(j_surface.obj());
-        ReleaseSurface(j_surface.obj());
+        Surface::Release(j_surface.obj());
       }
     }
   }
 }
 
-SurfaceTexturePeerBrowserImpl::SurfaceTexturePeerBrowserImpl(
-    bool player_in_render_process)
-    : player_in_render_process_(player_in_render_process) {
+SurfaceTexturePeerBrowserImpl::SurfaceTexturePeerBrowserImpl() {
 }
 
 SurfaceTexturePeerBrowserImpl::~SurfaceTexturePeerBrowserImpl() {
-  if (surface_.obj())
-    ReleaseSurface(surface_.obj());
 }
 
 void SurfaceTexturePeerBrowserImpl::EstablishSurfaceTexturePeer(
     base::ProcessHandle render_process_handle,
     SurfaceTextureTarget type,
     scoped_refptr<SurfaceTextureBridge> surface_texture_bridge,
     int render_view_id,
     int player_id) {
   if (!surface_texture_bridge)
     return;
 
   JNIEnv* env = base::android::AttachCurrentThread();
   DCHECK(env);
-  if (player_in_render_process_) {
-    Java_BrowserProcessSurfaceTexture_establishSurfaceTexturePeer(
-        env, render_process_handle, type,
-        surface_texture_bridge->j_surface_texture().obj(),
-        render_view_id, player_id);
-  } else {
-    BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, base::Bind(
-        &SetSurfacePeer, surface_texture_bridge, render_process_handle,
-        render_view_id, player_id));
-  }
-}
-
-bool SurfaceTexturePeerBrowserImpl::RegisterBrowserProcessSurfaceTexture(
-    JNIEnv* env) {
-  return RegisterNativesImpl(env);
+  BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, base::Bind(
+      &SetSurfacePeer, surface_texture_bridge, render_process_handle,
+      render_view_id, player_id));
 }
 
 }  // namespace content