Android: Remove Surface cruft

content/renderer/render_view_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_view_impl.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/bind.h"
@@ skipping 2684 matching lines @@
       GetWebView()->sharedGraphicsContext3D();
 
   GpuChannelHost* gpu_channel_host =
       RenderThreadImpl::current()->EstablishGpuChannelSync(
           CAUSE_FOR_GPU_LAUNCH_VIDEODECODEACCELERATOR_INITIALIZE);
   if (!gpu_channel_host) {
     LOG(ERROR) << "Failed to establish GPU channel for media player";
     return NULL;
   }
 
-  if (cmd_line->HasSwitch(switches::kMediaPlayerInRenderProcess)) {
+  if (cmd_line->HasSwitch(switches::kInProcessWebGL)) {

[bulach, 2013/03/04 10:44:51]

nit: is this right?

[no sievers, 2013/03/04 18:09:52]

Sort of :)
This code is currently unused I think, but Min wants to keep it. It's meant for
testing, where taking the same path here as CreateGraphicsContext3D() in this
file (which checks the same cmdline) should be the right thing.
I want to get rid of the 'InRendererProcess' command line, because that is
deprecated. For testing it's really something else (it's running single-process,
and is probably mocking browser-side parts).

     if (!media_bridge_manager_.get()) {
       media_bridge_manager_.reset(
           new webkit_media::MediaPlayerBridgeManagerImpl(1));
     }
     return new webkit_media::WebMediaPlayerInProcessAndroid(
         frame,
         client,
         cookieJar(frame),
         media_player_manager_.get(),
         media_bridge_manager_.get(),
@@ skipping 3921 matching lines @@
 }
 #endif
 
 void RenderViewImpl::OnReleaseDisambiguationPopupDIB(
     TransportDIB::Handle dib_handle) {
   TransportDIB* dib = TransportDIB::CreateWithHandle(dib_handle);
   RenderProcess::current()->ReleaseTransportDIB(dib);
 }
 
 }  // namespace content