Enable Ash panels for whitelisted v1 apps without flag

Enable Ash panels for whitelisted v1 apps without flag


BUG=178951
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=185358

[stevenjb, 2013-02-28 21:43:42]

OK, I've been using this a bit and it seems pretty stable, let's turn it on by
default for 27!

jeremya@ for OWNER

[flackr, 2013-02-28 21:53:43]

We should remove or reverse the flag shouldn't we?

[stevenjb, 2013-02-28 22:24:39]

On 2013/02/28 21:53:43, flackr wrote:
> We should remove or reverse the flag shouldn't we?

The flag is also used to enable panels regardless of the extension whitelist in
PanelManager::ShouldUsePanels(); I had just made it required for Ash
temporarily.

I don't think we want to make this a user option (confirmed with joshwoodward@),
and we can always revert this later if there are too many problems.

[flackr, 2013-02-28 22:26:34]

On 2013/02/28 22:24:39, stevenjb (chromium) wrote:
> On 2013/02/28 21:53:43, flackr wrote:
> > We should remove or reverse the flag shouldn't we?
> 
> The flag is also used to enable panels regardless of the extension whitelist
in
> PanelManager::ShouldUsePanels(); I had just made it required for Ash
> temporarily.
> 
> I don't think we want to make this a user option (confirmed with
joshwoodward@),
> and we can always revert this later if there are too many problems.

Ah fair enough. LGTM and I'm excited to have them on by default :-).

[jeremya, 2013-02-28 23:02:35]

lgtm, but please work with UI review to make sure this is suitable for release
:)

[stevenjb, 2013-02-28 23:05:41]

On 2013/02/28 23:02:35, jeremya wrote:
> lgtm, but please work with UI review to make sure this is suitable for release
> :)

We definitely have been :) Thanks.

[stevenjb, 2013-02-28 23:11:16]

Committed patchset #1 manually as r185358 (presubmit successful).