Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Unified Diff: runtime/observatory/tests/service/read_stream_test.dart

Issue 1238803002: Make observatory tests analyzer clean (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/read_stream_test.dart
diff --git a/runtime/observatory/tests/service/read_stream_test.dart b/runtime/observatory/tests/service/read_stream_test.dart
index 5bd2689bcfa9829ad91bd877fac532052bad7488..d2e669d4cc570f48ccb3cced00382c29770c6194 100644
--- a/runtime/observatory/tests/service/read_stream_test.dart
+++ b/runtime/observatory/tests/service/read_stream_test.dart
@@ -4,7 +4,7 @@
// VMOptions=--compile_all --error_on_bad_type --error_on_bad_override
import 'package:observatory/object_graph.dart';
-import 'package:expect/expect.dart';
+import 'package:unittest/unittest.dart';
import 'dart:typed_data';
testRoundTrip(final int n) {
@@ -22,20 +22,20 @@ testRoundTrip(final int n) {
var stream = new ReadStream([typedBytes]);
stream.readUnsigned();
- Expect.equals(n == 0, stream.isZero);
+ expect(n == 0, equals(stream.isZero));
- Expect.equals((n >> 0) & 0xFFFFFFF, stream.low);
- Expect.equals((n >> 28) & 0xFFFFFFF, stream.mid);
- Expect.equals((n >> 56) & 0xFFFFFFF, stream.high);
+ expect((n >> 0) & 0xFFFFFFF, equals(stream.low));
rmacnak 2015/07/14 20:44:47 Really, these should all flip so the expected valu
Cutch 2015/07/14 20:49:15 Done.
+ expect((n >> 28) & 0xFFFFFFF, equals(stream.mid));
+ expect((n >> 56) & 0xFFFFFFF, equals(stream.high));
const kMaxUint32 = (1 << 32) - 1;
if (n > kMaxUint32) {
- Expect.equals(kMaxUint32, stream.clampedUint32);
+ expect(kMaxUint32, equals(stream.clampedUint32));
} else {
- Expect.equals(n, stream.clampedUint32);
+ expect(n, equals(stream.clampedUint32));
}
- Expect.equals(bytes.length, stream.position);
+ expect(bytes.length, equals(stream.position));
}
main() {
« no previous file with comments | « runtime/observatory/tests/service/pause_on_exceptions_test.dart ('k') | runtime/observatory/tests/ui/inspector.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698