Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1238793004: Ship sandbox changes. (Closed)

Created:
5 years, 5 months ago by Mike West
Modified:
5 years, 5 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ship sandbox changes. This patch enables the two changes specified at [1]: 'allow-modals', and 'allow-popups-to-escape-sandbox'. Intent to ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wXbgxLu63Fo [1]: https://wiki.whatwg.org/index.php?title=Iframe_sandbox_improvments BUG=487157, 483624 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199016

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M Source/platform/RuntimeEnabledFeatures.in View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Mike West
Assuming there's another LGTM on the thread in the morning, WDYT about this CL? -mike
5 years, 5 months ago (2015-07-14 22:40:50 UTC) #1
jochen (gone - plz use gerrit)
there isn't one yet :-/
5 years, 5 months ago (2015-07-15 13:34:59 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-15 21:38:36 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238793004/1
5 years, 5 months ago (2015-07-15 21:47:30 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/70611)
5 years, 5 months ago (2015-07-16 02:14:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1238793004/1
5 years, 5 months ago (2015-07-16 06:52:13 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-16 08:19:10 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199016

Powered by Google App Engine
This is Rietveld 408576698